-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module data fixtures for @magentoDataFixtureBeforeTransaction annotations #21465
Module data fixtures for @magentoDataFixtureBeforeTransaction annotations #21465
Conversation
Hi @Vinai. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @larsroettig, thank you for the review. |
…nnotations Extend the option to specify a module based data fixture files to the @magentoDataFixtureBeforeTransaction annotation. Previously they where only available for the @magentoDataFixture annotation. The syntax is the same: @magentoDataFixtureBeforeAnnotation Foo_DataFixtureDummy::Test/Integration/foo.php There is no backward compatibility break associated with this commit.
798213a
to
18a590f
Compare
Thanks for your review @larsroettig. I've added a |
Hi @Vinai, thank you for your contribution! |
…ction annotations #21465
Description (*)
Extend the option to specify a module based data fixture files for integration tests to the
@magentoDataFixtureBeforeTransaction
annotation.Previously they where only available for the
@magentoDataFixture
annotation.The syntax is the same:
There is no backward compatibility break associated with this commit.
The PR also adds previously missing test coverage for same functionality for the
@magentoDataFixture
test annotation. Since the code from this PR is identical to that code, I decided against adding a test for@magentoDataFixtureBeforeTransaction
, too.Fixed Issues (if relevant)
There is no relevant open issue I'm aware of.
Manual testing scenarios (*)
@magentoDataFixtureBeforeTransaction Magento_InventoryCatalog::Test/_file/products_all_types.php
Contribution checklist (*)