-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] magento/magento2#20773: Do not throw exception during autoload #21435
[Backport] magento/magento2#20773: Do not throw exception during autoload #21435
Conversation
Hi @amol2jcommerce. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @amol2jcommerce, let's wait a little bit just in case author of original PR would like to create a backport ;) |
@orlangur please review. |
Perfect @amol2jcommerce 😉 |
Hi @orlangur, thank you for the review. |
✔️ QA passed |
Hi @amol2jcommerce, thank you for your contribution! |
Original Pull Request
#20950
Description (*)
Avoid uncaught exceptions during autoloading. PSR-4 dictates that must not happen. Return false instead.
Instead, try to log the exception message.
Fixed Issues (if relevant)
#20773
Manual testing scenarios (*)
Run
class_exists(FooFactory::class);
.More information to reproduce the problem is in the issue thread.
Contribution checklist (*)