-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix-issue-21292 Google Analytics isAnonymizedIpActive always true #21303
Conversation
Hi @Nazar65. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @sidolov, thank you for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t it be converted to bool?
Hi @ihor-sviziev yes i agree with you, but i'm also have another thing, maybe add this type (bool) to |
Hi @ihor-sviziev, thank you for the review. |
✔️ QA Passed |
Hi @Nazar65, thank you for your contribution! |
Description (*)
Google Analycs correctly activated and Anonymize Ip turned to off.
If (config.pageTrackingData.isAnonymizedIpActive)
return always true because this is not bool typeisAnonymizedIpActive
-> return bool, butgetValue
inisAnonymizedIpActive
- return mixed string or null so condition looks like if ("0") {ga("set", "anonymizeIp", true)}and
if ("0")
return trueFixed Issues (if relevant)
Manual testing scenarios (*)
1 - Install and activate GA Debbugger chrome extension
2 - Open the chrome console and browse the shop
Contribution checklist (*)