Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-issue-21292 Google Analytics isAnonymizedIpActive always true #21303

Merged
merged 3 commits into from
Mar 5, 2019
Merged

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Feb 18, 2019

Description (*)

Google Analycs correctly activated and Anonymize Ip turned to off.

deepinscreenshot_select-area_20190218164042

If (config.pageTrackingData.isAnonymizedIpActive) return always true because this is not bool type

isAnonymizedIpActive -> return bool, but getValue in isAnonymizedIpActive - return mixed string or null so condition looks like if ("0") {ga("set", "anonymizeIp", true)}
and if ("0") return true
deepinscreenshot_select-area_20190218171343

Fixed Issues (if relevant)

  1. Google Analytics isAnonymizedIpActive always true #21292: Google Analytics isAnonymizedIpActive always true
  2. ...

Manual testing scenarios (*)

1 - Install and activate GA Debbugger chrome extension
2 - Open the chrome console and browse the shop

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4313 has been created to process this Pull Request

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t it be converted to bool?

@Nazar65
Copy link
Member Author

Nazar65 commented Feb 20, 2019

Hi @ihor-sviziev yes i agree with you, but i'm also have another thing, maybe add this type (bool) to isAnonymizedIpActive ?
deepinscreenshot_select-area_20190220194840

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4313 has been created to process this Pull Request

@soleksii
Copy link

soleksii commented Mar 4, 2019

✔️ QA Passed

@ghost
Copy link

ghost commented Mar 5, 2019

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants