Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Issue #20924 - fix Pending Reviews label, add menu for pending review #21174

Closed

Conversation

gelanivishal
Copy link
Contributor

Original Pull Request

#20936

Description (*)

Fixed Issues (if relevant)

  1. Reviews ACL issue - showing Reviews menu two times under System > User Roles > Add New Role > Role Resources #20924: Reviews ACL issue - showing Reviews menu two times under System > User Roles > Add New Role > Role Resources

Manual testing scenarios (*)

  1. Go to System > User Roles > Add New Role > Role Resources. Changed label for Pending Reviews menu. Screenshot
  2. Added Pending Reviews menu under Marketing > User Content. Screenshot
  3. Edit a review from Pending Reviews grid then on click Back button it was redirecting to the wrong path.
  4. Edit a review from Pending Reviews grid then on Save Review it was redirecting to the wrong path. Screenshot

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

dankhrapiyush and others added 2 commits February 13, 2019 10:35
… reviews, fix delete review alert and redirect issue if go to edit page from pending review grid
@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21174.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@dmytro-ch
Copy link
Contributor

Hi @gelanivishal,
there is an error while saving the review.

Fatal error: Interface 'Magento\Review\Controller\Adminhtml\Product\HttpPostActionInterface' not found in app/code/Magento/Review/Controller/Adminhtml/Product/Save.php on line 15

Could you please update the current solution in order to make it compatible with 2.2.x version.

Thank you!

@sidolov
Copy link
Contributor

sidolov commented Feb 28, 2019

@gelanivishal , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Feb 28, 2019
@ghost
Copy link

ghost commented Feb 28, 2019

Hi @gelanivishal, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants