Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small PHPDocs fixes #20295

Merged
merged 5 commits into from Apr 18, 2019
Merged

Small PHPDocs fixes #20295

merged 5 commits into from Apr 18, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 15, 2019 •
edited by ghost
Loading

Description

  • Small PHPDocs fixes in Theme module
  • Deleted unused local variable

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @SikailoISM. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Theme Release Line: 2.3 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Jan 15, 2019
@orlangur orlangur self-assigned this Jan 15, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4670 has been created to process this Pull Request

@nmalevanec nmalevanec self-assigned this Apr 16, 2019
@magento-engcom-team magento-engcom-team merged commit f266f4b into magento:2.3-develop Apr 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 18, 2019

Hi @SikailoISM, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 18, 2019
magento-engcom-team pushed a commit that referenced this pull request Apr 18, 2019
@sivaschenko
ENGCOM-4670: Small PHPDocs fixes #20295
41dad46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@orlangur orlangur

@nmalevanec nmalevanec

Labels
Cleanup Component: Theme Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@magento-engcom-team @orlangur @nmalevanec