fixed issue of Backup tool not correctly detecting .maintenance.flag #19993

hiren0241 · 2018-12-27T14:10:54Z

Fixed issue of Backup tool not correctly detecting .maintenance.flag

Description (*)

This PR fix the issue of backup tool not correct detecting .maintenance.flag issue in Magento 2.3.0.

Fixed Issues (if relevant)

Magento 2.3.0: Backup tool not correctly detecting .maintenance.flag #19825: Magento 2.3.0: Backup tool not correctly detecting .maintenance.flag

Manual testing scenarios (*)

Case 1:

Go to Dashboard -> System -> Tools -> Backups -> Database Backup
Enter backup name, check "Maintenance mode", click OK.
Back up is created

Case 2:

Go to Dashboard -> System -> Tools -> Backups -> Database Backup
Enter backup name, and click OK.
Back up is created.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

magento-engcom-team · 2018-12-27T14:10:58Z

Hi @hiren0241. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

hiren0241 · 2018-12-28T08:50:36Z

Hi @sidolov ,
Will you please guide me how can I pass travis check? As I am unable to debug where it fails.

orlangur · 2018-12-28T11:40:23Z

@hiren0241 what do you mean? You can see failed unit tests here: https://travis-ci.org/magento/magento2/jobs/472906682

hiren0241 · 2018-12-28T11:47:22Z

Hi @orlangur,

Thanks for your response.

I did analysis on error but I didn't change anything in unit testing or for that particular stuff but still it's showing CI fails. SO, I am confused which thing preventing the build.

One more thing, In travis job log it's suggest below listed things:

Magento\Backup\Test\Unit\Controller\Adminhtml\Index\CreateTest::testExecutePermission
Expectation failed for method name is equal to "get" when invoked zero or more times
Parameter 0 for invocation Magento\Framework\ObjectManagerInterface::get('Psr\Log\LoggerInterface') does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Magento\Backup\Helper\Data'
+'Psr\Log\LoggerInterface'
/home/travis/build/magento/magento2/app/code/Magento/Backup/Controller/Adminhtml/Index/Create.php:94
/home/travis/build/magento/magento2/app/code/Magento/Backup/Test/Unit/Controller/Adminhtml/Index/CreateTest.php:238

But, this is default magento stuff. What's wrong with it that I can't understand. So, I am asking for help.

Please share your valuable knowledge on this so that I can resolve this issue.

Thanks in advance.

orlangur · 2018-12-28T11:49:15Z

@hiren0241 you changed code covered by this test, it means that either changes (if they do not work for all cases) or the test should be adjusted so that they match each other again.

hiren0241 · 2018-12-28T11:56:50Z

Thanks @orlangur,

I understand. Will you please review my changes so that I can get assurance that my changes fix the issue but now I have to look into unit testing stuff. Is it possible for you to review it or I have to fix travis stuff first?

Please do the needful.

magento-engcom-team · 2019-01-08T17:32:48Z

@hiren0241 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

hiren0241 · 2019-01-12T06:59:37Z

@magento-engcom-team Is My PR accepted? or should I have to update test code by myself?

sivaschenko · 2019-01-16T21:34:41Z

@hiren0241 you need to adjust the failed unit test to your changes. Please let me know if you need any assistance on fixing unit tests. Feel free to reach me i.e. in magentocommeng slack.

sivaschenko · 2019-01-22T11:45:32Z

Discussed the test fail with @hiren0241 and decided to try to rework the fix shifting attention towards \Magento\Framework\App\MaintenanceMode::set method return.

sidolov · 2019-02-06T20:43:02Z

Hi @hiren0241 , please, take a look at failed tests

travis5491811 · 2019-02-06T20:57:30Z

I noticed you all are working on backup tool. Is it not really deprecated? If not, any idea why docs are saying it is?

Deprecation Notice! Magento backup features are deprecated as of v2.3.0. We recommend that all merchants investigate additional backup technologies and binary backup tools (such as Percona XtraBackup).

sivaschenko · 2019-02-21T13:05:04Z

Closing this pull request due to inactivity, feel free to reopen if you'd like to continue progress

ghost · 2019-02-21T13:05:06Z

Hi @hiren0241, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

hiren0241 · 2019-03-11T09:19:33Z

@sivaschenko Hi,
I am reopening this PR, As I would like to continue working upon it.

sivaschenko · 2019-04-16T12:30:56Z

app/code/Magento/Backup/Controller/Adminhtml/Index/Create.php

-                }
+                $this->maintenanceMode->set(true);
+            } else {
+                $response->setError(


Displaying insufficient permissions error in case maintenance_mode parameter is false is logically incorrect

hiren0241 · 2019-04-18T13:47:31Z

Hi @stoleksiy ,
Author of issue has didn't mention regarding rollback, And even though this fixed is only for create back up not for rollback.

If you want this changes for rollback as well, than I will apply same logic over there.

Please guide me for the same.

Thanks in advance.

soleksii · 2019-04-18T14:08:36Z

@hiren0241 Thanks for the answer! Could you please make these changes in scope of this PR?

hiren0241 · 2019-04-18T14:10:47Z

@stoleksiy , Sure, I Will do the same. Will update you in sometime after commit the changes.

soleksii · 2019-04-18T14:12:52Z

@hiren0241 Thanks!

hiren0241 · 2019-04-18T14:30:57Z

@stoleksiy,

Please re-test it now.

Thanks.

hiren0241 · 2019-04-18T14:31:19Z

@magento-engcom-team give me test instance

magento-engcom-team · 2019-04-18T14:31:22Z

Hi @hiren0241. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-04-18T14:31:23Z

Hi @sivaschenko, thank you for the review.
ENGCOM-4782 has been created to process this Pull Request

magento-engcom-team · 2019-04-18T14:32:22Z

Hi @hiren0241, here is your new Magento instance.
Admin access: https://pr-19993.instances.magento-community.engineering/admin
Login: admin Password: 123123q

soleksii · 2019-04-18T14:56:09Z

✔️ QA Passed

…19825

m2-assistant · 2019-04-23T12:26:46Z

Hi @hiren0241, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

…tenance.flag magento#19993

magento-engcom-team added Component: Backup Release Line: 2.3 Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Dec 27, 2018

sivaschenko assigned sivaschenko and unassigned sivaschenko Jan 8, 2019

magento-engcom-team assigned sivaschenko Jan 8, 2019

magento-engcom-team added this to the Release: 2.3.1 milestone Jan 8, 2019

sivaschenko added the Progress: needs update label Jan 22, 2019

okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019

sivaschenko closed this Feb 21, 2019

hiren0241 reopened this Mar 11, 2019

ghost unassigned sivaschenko Mar 11, 2019

sidolov removed the Progress: needs update label Mar 11, 2019

sivaschenko requested changes Apr 16, 2019

View reviewed changes

ghost added Progress: needs update and removed Progress: testing in progress labels Apr 18, 2019

Resolve Rollback issue

6374f9d

sivaschenko approved these changes Apr 18, 2019

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Apr 18, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Apr 18, 2019

ghost added Progress: extended testing and removed Progress: testing in progress labels Apr 18, 2019

nmalevanec self-assigned this Apr 19, 2019

nmalevanec added 2 commits April 19, 2019 14:22

Merge remote-tracking branch 'mainline/2.3-develop' into fixed-issue-…

658b5a7

…19825

Fix static tests.

5bc05b2

ghost added Progress: accept and removed Progress: extended testing labels Apr 19, 2019

magento-engcom-team mentioned this pull request Apr 23, 2019

Magento 2.3.0: Backup tool not correctly detecting .maintenance.flag #19825

Closed

magento-engcom-team merged commit 5bc05b2 into magento:2.3-develop Apr 23, 2019

magento-engcom-team added this to the Release: 2.3.2 milestone Apr 23, 2019

taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Apr 23, 2019

ENGCOM-4782: fixed issue of Backup tool not correctly detecting .main…

a970760

…tenance.flag magento#19993

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixed issue of Backup tool not correctly detecting .maintenance.flag #19993

fixed issue of Backup tool not correctly detecting .maintenance.flag #19993

hiren0241 commented Dec 27, 2018 •

edited

Loading

magento-engcom-team commented Dec 27, 2018

hiren0241 commented Dec 28, 2018

orlangur commented Dec 28, 2018

hiren0241 commented Dec 28, 2018

orlangur commented Dec 28, 2018

hiren0241 commented Dec 28, 2018

magento-engcom-team commented Jan 8, 2019

hiren0241 commented Jan 12, 2019

sivaschenko commented Jan 16, 2019

sivaschenko commented Jan 22, 2019

sidolov commented Feb 6, 2019

travis5491811 commented Feb 6, 2019

sivaschenko commented Feb 21, 2019

ghost commented Feb 21, 2019

hiren0241 commented Mar 11, 2019

sivaschenko Apr 16, 2019

hiren0241 commented Apr 18, 2019

soleksii commented Apr 18, 2019

hiren0241 commented Apr 18, 2019

soleksii commented Apr 18, 2019

hiren0241 commented Apr 18, 2019

hiren0241 commented Apr 18, 2019

magento-engcom-team commented Apr 18, 2019

magento-engcom-team commented Apr 18, 2019

magento-engcom-team commented Apr 18, 2019

soleksii commented Apr 18, 2019

m2-assistant bot commented Apr 23, 2019

fixed issue of Backup tool not correctly detecting .maintenance.flag #19993

fixed issue of Backup tool not correctly detecting .maintenance.flag #19993

Conversation

hiren0241 commented Dec 27, 2018 • edited Loading

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

magento-engcom-team commented Dec 27, 2018

hiren0241 commented Dec 28, 2018

orlangur commented Dec 28, 2018

hiren0241 commented Dec 28, 2018

orlangur commented Dec 28, 2018

hiren0241 commented Dec 28, 2018

magento-engcom-team commented Jan 8, 2019

hiren0241 commented Jan 12, 2019

sivaschenko commented Jan 16, 2019

sivaschenko commented Jan 22, 2019

sidolov commented Feb 6, 2019

travis5491811 commented Feb 6, 2019

sivaschenko commented Feb 21, 2019

ghost commented Feb 21, 2019

hiren0241 commented Mar 11, 2019

sivaschenko Apr 16, 2019

Choose a reason for hiding this comment

hiren0241 commented Apr 18, 2019

soleksii commented Apr 18, 2019

hiren0241 commented Apr 18, 2019

soleksii commented Apr 18, 2019

hiren0241 commented Apr 18, 2019

hiren0241 commented Apr 18, 2019

magento-engcom-team commented Apr 18, 2019

magento-engcom-team commented Apr 18, 2019

magento-engcom-team commented Apr 18, 2019

soleksii commented Apr 18, 2019

m2-assistant bot commented Apr 23, 2019

hiren0241 commented Dec 27, 2018 •

edited

Loading