-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent display of token when save for later is not selected #19767
Conversation
This sets the token `isVisible` value to faluse if `VaultConfigProvider::IS_ACTIVE_CODE` is not set in the payment's `additionalInformation` property. The value is not set when placing orders through the admin panel, unless the save for later checkbox is selected. This caused all admin order payment to be visible in the stored payment method section in the storefront. Fixes magento#19515 Testing on 2.3 depends on magento#19764
Hi @pmclain. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@pmclain, Unfortunately, the original issue is considered as expected behavior. Thank you! |
Hi @pmclain, thank you for your contribution! |
@dmytro-ch The expected behaviour outlined in the issue does NOT work. |
Hi @sivaschenko, thank you for the review. |
✔️ QA passed |
Hi @pmclain, thank you for your contribution! |
Description
This sets the token
isVisible
value to false ifVaultConfigProvider::IS_ACTIVE_CODE
is not set in the payment'sadditionalInformation
property. The value is not set when placing ordersthrough the admin panel, unless the save for later checkbox is selected. This
caused all admin order payment to be visible in the stored payment method
section in the storefront.
Testing on 2.3 depends on #19764
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist (*)