Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'target' attribute to the allowed attributes array for link block #1935

Merged
merged 1 commit into from
Sep 22, 2016

Conversation

facundocapua
Copy link
Contributor

Added the 'target' property to the $allowedAttributes array, so it can be changed from the layout, like the following example:

 <block class="Magento\Framework\View\Element\Html\Link" name="a-blank-page-link">
    <arguments>
        <argument name="path" xsi:type="string">a-blank-page.html</argument>
        <argument name="target" xsi:type="string">_blank</argument>
        <argument name="label" xsi:type="string" translate="true">A blank page</argument>
    </arguments>
</block>

@okorshenko okorshenko added the PS label Sep 24, 2015
@magento-cicd2
Copy link
Contributor

We have automated a Magento Contributor License Agreement verifier for contributions sent to our GitHub projects.
Please see the CLA agreement in the Pull Request comments below.

@KrystynaKabannyk
Copy link

Hello @fcapua-summa, can you please update the code and cover it by Travis tests?

@facundocapua
Copy link
Contributor Author

It seems that they are still failing, should I try restarting it again?

@vkorotun vkorotun added Area: Frontend and removed PS labels Aug 3, 2016
@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept labels Sep 14, 2016
@vkorotun
Copy link
Contributor

Internal ticket: MAGETWO-58372

@mmansoor-magento mmansoor-magento merged commit 2056e4b into magento:develop Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants