CSV files: added possibility to select PHP input file mode #14610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enrico69
changed the title
sidolov
requested changes
Apr 10, 2018
| */ | ||
| public function saveData($file, $data) | ||
| public function saveData($file, $data, $mode = 'w') |
There was a problem hiding this comment.
Please, add new method parameters according to our Backward Compatible Development Guide
There was a problem hiding this comment.
Done. But in my very humble opinion, it makes the code bloated. My first proposal was not breaking backward compatibility and kept the original code.
sidolov
approved these changes
May 3, 2018
|
Hi @sidolov, thank you for the review. |
|
Hi @enrico69. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small modification to the CSV processor of the framework. This processeur is juste a layer
over native PHP functions. However it forces the input mode when writing into a file which is very unpleasant and lacks of flexibility.
For instance, if you want to progressively save the data in to the file, you can't: you have to save it at once. It could lead to have big amount of data stored in memory while it could be saved progressively in the file.
This small modification allows to developer to choose the input mode while not breaking the backward compatibility.
Manual testing scenarios
Contribution checklist