Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter update for post method in http client interface #14481

Conversation

simpleadm
Copy link
Contributor

@simpleadm simpleadm commented Mar 31, 2018

Updated $params parameter for post method of \Magento\Framework\HTTP\ClientInterface interface.

Description

Currently all classes that implement \Magento\Framework\HTTP\ClientInterface interface already have (or will have soon in all branches) support of string in post method. So current PR populate that useful ability to the interface.

Related issue and PRs

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@larsroettig larsroettig self-assigned this Apr 1, 2018
@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 1, 2018
@magento-engcom-team
Copy link
Contributor

Hi @larsroettig, thank you for the review.
ENGCOM-1199 has been created to process this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants