-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed all templates made obsolete by Mage_Persistent #131
Conversation
I tried to create an integration test but got complete stuck. What should be tested? That the loaded template is the right one? That certain elements are shown in the right page (i.e. email input in login page)? I am also not sure how to correctly setup the TAF. I never used Selenium and couldn't get it to work. To be honest I didn't put a lot of effort into figuring it out either |
Hi @barbazul, than you for the actual implementation. However, we cannot accept it, because it conflicts with Magento's modularity principle. We've explained it in #70. However, pushing this idea, you made us think and schedule fixing this issue. We will implement it and publish to GitHub. Thank you. |
…ble-varnish [Extensibility] Bugfix
- Move Сarrier Сodes validation to service layer - Add New intigration Test
- Add Export Command
- Refactoring for validate function - Add expectedErrorData to api test
- Fix API Test
- Fix API Test - Add Type Hint
…-validation Move Сarrier Сodes validation to service layer magento#131
Removed all templates made obsolete by Mage_Persistent as discussed in #70