Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all templates made obsolete by Mage_Persistent #131

Closed
wants to merge 1 commit into from

Conversation

barbazul
Copy link
Contributor

Removed all templates made obsolete by Mage_Persistent as discussed in #70

@barbazul
Copy link
Contributor Author

I tried to create an integration test but got complete stuck. What should be tested? That the loaded template is the right one? That certain elements are shown in the right page (i.e. email input in login page)?

I am also not sure how to correctly setup the TAF. I never used Selenium and couldn't get it to work.
I do use PHPUnit regularly but it looks like the tests provided with magento2 are using some customized version of it because they don't work at all in my box (PHPUnit dies with a fatal error)

To be honest I didn't put a lot of effort into figuring it out either

@magento-team
Copy link
Contributor

Hi @barbazul,

than you for the actual implementation. However, we cannot accept it, because it conflicts with Magento's modularity principle. We've explained it in #70.

However, pushing this idea, you made us think and schedule fixing this issue. We will implement it and publish to GitHub.

Thank you.

joanhe pushed a commit that referenced this pull request Nov 5, 2015
VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this pull request Nov 25, 2017
- Move Сarrier Сodes validation to service layer
- Add New intigration Test
VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this pull request Nov 25, 2017
- Add Export Command
VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this pull request Nov 25, 2017
- Refactoring for validate function
- Add expectedErrorData to api test
VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this pull request Nov 25, 2017
- Fix API Test
VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this pull request Nov 25, 2017
- Fix API Test
- Add Type Hint
VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this pull request Nov 25, 2017
…-validation

Move Сarrier Сodes validation to service layer magento#131
magento-engcom-team pushed a commit that referenced this pull request Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants