Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9764: exception message is wrong and misleading in findAccessorMethodName() of Magento\Framework\Reflection\NameFinder #12303

Merged
merged 2 commits into from
Nov 16, 2017

Conversation

RomaKis
Copy link
Contributor

@RomaKis RomaKis commented Nov 16, 2017

Exception message is wrong and misleading in findAccessorMethodName() of Magento\Framework\Reflection\NameFinder

Fixed Issues (if relevant)

  1. exception message is wrong and misleading in findAccessorMethodName() of Magento\Framework\Reflection\NameFinder #9764: exception message is wrong and misleading in findAccessorMethodName() of Magento\Framework\Reflection\NameFinder

Manual testing scenarios

  1. This function gets getter name and It call findAccessorMethodName()
{
$getterName = 'get' . $camelCaseProperty;
$boolGetterName = 'is' . $camelCaseProperty;
return $this->findAccessorMethodName($class, $camelCaseProperty, $getterName, $boolGetterName);
}

In my case,

$getterName = getIsDefaultBilling
$class->name = "Magento\Customer\Api\Data\AddressInterface"

Expected result:
Exception: 'Property "IsDefaultBilling" does not have accessor method "getIsDefaultBilling" in class "Magento\Customer\Api\Data\AddressInterface.',

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…Name() of Magento\Framework\Reflection\NameFinder
…Name() of Magento\Framework\Reflection\NameFinder
@magento-engcom-team magento-engcom-team added bugfix Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 16, 2017
@osrecio osrecio self-assigned this Nov 16, 2017
@osrecio osrecio added this to the November 2017 milestone Nov 16, 2017
@osrecio
Copy link
Member

osrecio commented Nov 16, 2017

Thanks for your contribution @RomaKis ! Can you please squash your commits? If you don't know how to make it, Can I help you.

@okorshenko okorshenko self-assigned this Nov 16, 2017
@okorshenko
Copy link
Contributor

I think we can accept it without squash. @osrecio thank you for review 👍

@okorshenko okorshenko merged commit 0a76034 into magento:2.2-develop Nov 16, 2017
okorshenko pushed a commit that referenced this pull request Nov 16, 2017
…dAccessorMethodName() of Magento\Framework\Reflection\NameFinder #12303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants