Error message for duplicated phrases not allowed in Generator.php #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctubio
force-pushed
the
generator_phrases_error
branch
from
b561751
to
c212b35
Compare
ctubio
force-pushed
the
generator_phrases_error
branch
from
c212b35
to
f96096b
Compare
vpelipenko
added
Progress: accept
Issue: Ready for Work
|
CR: passed |
vpelipenko
added a commit
that referenced
this pull request
Apr 30, 2015
Error message for duplicated phrases not allowed in Generator.php
magento-team
pushed a commit
that referenced
this pull request
Jun 13, 2017
[Troll] MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 6, 2018
- Merge Pull Request magento-engcom/magento2ce#1185 from serhii-balko/magento2:github-11798 - Merged commits: 1. 451f7b9
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running dev/tools/Magento/Tools/I18n/pack.php, if duplicated translations are not allowed but duplicated translations are found, it displays a misleading error message:
It is not really true that each duplicated phrase is translated differently, is possible that they are translated equal, and people may potentially lose time while looking for the nonexistent differences in order to fix the error.
The error message is displayed when duplicated phrases are not allowed but some are found, regardless if they are translated equal or different.