Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message in product review form not being translated #11069

Merged
merged 4 commits into from
Oct 4, 2017

Conversation

Echron
Copy link
Member

@Echron Echron commented Sep 26, 2017

Description

Add a validator to validate the rating and add the message to the i18n file

Fixed Issues (if relevant)

  1. Error message in product review form not being translated #10474: Error message in product review form not being translated

Manual testing scenarios

  1. Make sure the review module is enabled and reviews are enabled on the product page
  2. Go to "Stores > Ratings" and make one rating is active and selected for the selected storeview in step 3
  3. Configure a storeview with a different language than en_US
  4. Try to submit an empty review on a product page

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

heyitsroberthe and others added 4 commits September 12, 2017 20:36
[mpi] MAGETWO-72551: Update version in composer to 2.2.1-dev for 2.2-develop branch
Add rating validation message to the i18n file
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 26, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ Echron
❌ paliarush
❌ viktym

@vrann vrann added Release Line: 2.2 Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Sep 26, 2017
@vrann vrann self-assigned this Sep 27, 2017
@vrann vrann added this to the September 2017 milestone Sep 27, 2017
@vrann vrann reopened this Sep 29, 2017
@okorshenko okorshenko merged commit eb63bbb into magento:2.2-develop Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants