#865: add getParams/setParam to RequestInterface #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ashsmith Thanks for providing this pull request. In order for us to accept the PR we would need the Travis CI tests to pass though.
After making these changes, please make sure that there aren't any other issues identified by TravisCI. |
|
Working on fixing the failing tests. Didn't realise quite how many would be affected by this change. |
added 2 commits
February 20, 2015 17:23
…thub.com:ashsmith/magento2 into 865-add-getParams-setParams-to-request-interface Conflicts: dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute/SaveTest.php
|
Okay, I've updated the tests. I'm getting one failure locally that I can't debug where |
otoolec
added
the
Issue: Ready for Work
|
@ashsmith I've resolved the merge conflicts that exist and am submitting an internal PR for your code. This should allow us to accept your PR next week! I didn't see any errors related to |
|
@otoolec It was when running locally. I have a feeling it's to do with my local dev. I'll rebuild my vm tonight and run it again to be sure. |
vpelipenko
pushed a commit
to vpelipenko/magento2
that referenced
this pull request
Mar 5, 2015
…erface magento#865 magento#1053 Merge branch '865-add-getParams-setParams-to-request-interface' of git://github.com/ashsmith/magento2 into ashsmith-865-add-getParams-setParams-to-request-interface Conflicts: dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute/SaveTest.php dev/tests/unit/testsuite/Magento/Checkout/Helper/CartTest.php dev/tests/unit/testsuite/Magento/Checkout/Model/Type/OnepageTest.php dev/tests/unit/testsuite/Magento/Customer/Controller/Account/CreateTest.php dev/tests/unit/testsuite/Magento/Customer/Controller/Account/LoginPostTest.php dev/tests/unit/testsuite/Magento/Customer/Controller/Adminhtml/Index/IndexTest.php dev/tests/unit/testsuite/Magento/Customer/Controller/Ajax/LoginTest.php dev/tests/unit/testsuite/Magento/Customer/Model/Metadata/Form/FileTest.php dev/tests/unit/testsuite/Magento/Downloadable/Controller/Adminhtml/Downloadable/Product/Edit/LinkTest.php dev/tests/unit/testsuite/Magento/Downloadable/Controller/Adminhtml/Downloadable/Product/Edit/SampleTest.php dev/tests/unit/testsuite/Magento/Downloadable/Controller/Download/LinkTest.php dev/tests/unit/testsuite/Magento/Framework/App/Action/ActionTest.php dev/tests/unit/testsuite/Magento/Framework/App/Router/NoRouteHandlerTest.php dev/tests/unit/testsuite/Magento/Framework/Controller/Result/ForwardTest.php dev/tests/unit/testsuite/Magento/Framework/UrlTest.php
vpelipenko
pushed a commit
to vpelipenko/magento2
that referenced
this pull request
Mar 5, 2015
…erface magento#865 magento#1053 - Remove RequestInterface::getParam from obsolete_methods since it still exists - Move getCookie to PhpEnvironment\Request
magento-team
pushed a commit
that referenced
this pull request
Apr 24, 2017
Implemented task: - MAGETWO-66374 Add @api annotation
magento-engcom-team
added a commit
that referenced
this pull request
Nov 14, 2019
…reate new customer with the email of already existent user #1053 - Merge Pull Request magento/graphql-ce#1053 from magento/graphql-ce:createCustomer-test-coverage - Merged commits: 1. fe89ce4
magento-engcom-team
pushed a commit
that referenced
this pull request
Nov 14, 2019
…reate new customer with the email of already existent user #1053
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #865, the getParams and setParams method is missing from the RequestInterface. Which are methods relied upon heavily in app/code/Magento/*.