Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the reset button of UrlRewrite block to not cause JS errors #10462

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

dmanners
Copy link
Contributor

@dmanners dmanners commented Aug 8, 2017

Description

Currently the reset button on the url rewrite edit page causes a JavaScript error.

Fixed Issues (if relevant)

  1. Unable reset form in Edit URL Rewrite  #10459: Unable reset form in Edit URL Rewrite

Manual testing scenarios

  1. Visit the edit url rewrite form in the admin section,
  2. Make a change to the form and select the reset button,
  3. Page should be reloaded and form reset,

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@avoelkl avoelkl self-assigned this Aug 8, 2017
@avoelkl avoelkl added this to the August 2017 milestone Aug 8, 2017
@avoelkl avoelkl added the develop label Aug 8, 2017
@magento-team magento-team merged commit a8fa460 into magento:develop Aug 9, 2017
magento-team pushed a commit that referenced this pull request Oct 6, 2017
@dmanners dmanners deleted the fix-reset-button-for-urls branch December 19, 2017 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants