#996 add url fragment to pager #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Method chaining is considered harmful :) |
|
@antonkril Then you can remove the |
|
CR: passed |
vpelipenko
added a commit
that referenced
this pull request
Feb 12, 2015
#996 add url fragment to pager
mmansoor-magento
pushed a commit
to magento-mpi/magento2
that referenced
this pull request
May 9, 2016
[Ogre] Bug fix, MAGETWO-31889
magento-team
pushed a commit
that referenced
this pull request
Apr 20, 2017
[Falcons] Delivery of deployment improvements
magento-engcom-team
added a commit
that referenced
this pull request
Mar 24, 2018
…mage instead variation image #1031 - Merge Pull Request magento-engcom/magento2ce#1031 from RomaKis/magento2ce:8168 - Merged commits: 1. 93a5c39
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 24, 2018
…mage instead variation image #1031
fe-lix-
pushed a commit
to fe-lix-/magento2
that referenced
this pull request
Apr 29, 2018
Merge mainline
magento-engcom-team
added a commit
that referenced
this pull request
Nov 14, 2019
…Mutation createCustomerAddress #1031 - Merge Pull Request magento/graphql-ce#1031 from osrecio/graphql-ce:1029-postcode-required-customerCreate - Merged commits: 1. 676cd1b 2. 127835e 3. 891e5a4
magento-engcom-team
pushed a commit
that referenced
this pull request
Nov 14, 2019
…Mutation createCustomerAddress #1031
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for url fragment in the pager as discussed in #996 .
And while at it, I made the method
setAvailableLimitreturn$this. Originally it did not return anything and this made it unavailable for chaining.