Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2 2266 #10082

Merged
merged 3 commits into from
Jun 28, 2017
Merged

M2 2266 #10082

merged 3 commits into from
Jun 28, 2017

Conversation

tzyganu
Copy link
Contributor

@tzyganu tzyganu commented Jun 28, 2017

Description

This PR fixes #2266 where the actions dropdown menu is not aligned properly in the admin grids when the action column is not the last column.

Fixed Issue

  1. Action column menu does not stay over the action column #2266: Action column menu does not stay over the action column

Manual testing scenarios

  1. Open the admin panel.
  2. Go to the cms pages list: Content->Pages (from the main menu)
  3. After the grid is rendered add this code in the file app/code/Magento/Cms/view/adminhtml/ui_component/cms_page_listing.xml (I edited that file to make it easier to explain. It also happens if I add a new column using the file cms_page_listing.xml from my module also)
        <column name="dummy">
            <settings>
                <filter>text</filter>
                <editor>
                    <validation>
                        <rule name="validate-identifier" xsi:type="boolean">true</rule>
                    </validation>
                    <editorType>text</editorType>
                </editor>
                <label translate="true">Dummy</label>
            </settings>
        </column>

4.Refresh the pages list.
5. click on the actions link for the first item in the grid.

Expected result:

  • The actions menu is over the actions column

Actual Result

  • The actions menu is over the last column.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@tzyganu
Copy link
Contributor Author

tzyganu commented Jun 28, 2017

can someone please restart the tests. One fails due to a connection problem.

@miguelbalparda
Copy link
Contributor

Tests restarted.

@miguelbalparda miguelbalparda self-assigned this Jun 28, 2017
@miguelbalparda miguelbalparda added this to the June 2017 milestone Jun 28, 2017
@okorshenko okorshenko assigned okorshenko and unassigned okorshenko Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants