-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commit #7344 (Fix in CarrierFactory) not present in v2.1.5 #9175
Comments
Yep the commit 08b5177 is only present on branch develop http://take.ms/NyoJ1 meaning it will normally appear in 2.2 unless additional actions are taken. I am not sure if the Magento, Inc. has this additional step (backport any small bugfix into 2.0 and 2.1 branches as soon as it's fixed on develop) in their internal workflow. That would certainly be something a lot of people would benefit from, but unfortunately it is unlikely that the bugs "fixed in develop but not on 2.1" are even tracked anywhere. |
Wow thats a mindfuck, so hotfixes/bugfixes arent released in patches at all (2.1.xx)? Anyway we can speed this up, e.a. any forks/releases that include the develop bugfixes? Without the fixes its really cumbersome running Magento 2 on production enviroments |
Well most of the fixes are on the develop branch, but running a production instance with code from this branch is even more risky since it also contains unfinished features. You could make a fork, and cherry-pick those fixes one-by-one, but then again such a flow would require a lot of effort and defeat the usage of composer as such. For a small development team the "fix the most critical ones via di.xml" approach might just be the most cost-effective. There is one way we can speed it up though: if it's important for you enough, you could make a fork and produce a pull request targeted to the 2.1 branch (or rather 2.1-develop, not sure about this part). Making a pull request currently seems to get faster attention from core developers. |
@surajsanchit please format this issue according to the Issue reporting guidelines: with steps to reproduce, actual result and expected result. |
@veloraven, this is a request to backport a fix which is already accepted into the |
I'm starting to suspect more and more than veloraven is just a bot. |
@PascalBrouwers I believe you are right. |
@surajsanchit thank you for your report.
The issue does not exist in 2.2.0 which will be available soon. @PascalBrouwers thank you for being a part of Magento Community where everyone follow Code of Conduct |
Que? |
It's probably assumed to be something vague in between "Trolling, insulting/derogatory comments, and personal or political attacks" and not "Showing empathy towards other community members". Well guess what, forcing someone to edit the issue description weeks (which is already provided in the linked PR #7344 ) weeks after the fact - that isn't too empathetic neither. Speaking of "Code of Conduct", my previous message was clearly ignored. |
@surajsanchit we are closing this issue due to inactivity. If you'd like to update it, please reopen the issue. |
Commit #7344 Is not present in release 2.1.5 which causes shipping modules depending on storeview specific configurations not to behave as expected.
Seeing as the fix is merged on 07-11-2016 I would expect it to be available in the latest stable release.
The text was updated successfully, but these errors were encountered: