Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when I install at the last(Step 6: Install) ,96% can not continue. #670

Closed
magicento opened this issue Sep 20, 2014 · 5 comments
Closed

when I install at the last(Step 6: Install) ,96% can not continue. #670

magicento opened this issue Sep 20, 2014 · 5 comments
Assignees
@verklov
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@magicento
Copy link

qq20140920-18 2x

[SUCCESS] Magento_Core ... installed
[SUCCESS] Magento_Authorization ... installed
[SUCCESS] Magento_Store ... installed
[SUCCESS] Magento_Directory ... installed
[SUCCESS] Magento_Backup ... installed
[SUCCESS] Magento_Eav ... installed
[SUCCESS] Magento_Customer ... installed
[SUCCESS] Magento_Index ... installed
[SUCCESS] Magento_CatalogImportExport ... installed
[SUCCESS] Magento_Indexer ... installed
[SUCCESS] Magento_Theme ... installed
[SUCCESS] Magento_UrlRewrite ... installed
[SUCCESS] Magento_Cms ... installed
[SUCCESS] Magento_Catalog ... installed
[SUCCESS] Magento_CheckoutAgreements ... installed
[SUCCESS] Magento_Bundle ... installed
[SUCCESS] Magento_ConfigurableImportExport ... installed
[SUCCESS] Magento_Rule ... installed
[SUCCESS] Magento_Contact ... installed
[SUCCESS] Magento_AdminNotification ... installed
[SUCCESS] Magento_Cron ... installed
[SUCCESS] Magento_Widget ... installed
[SUCCESS] Magento_Payment ... installed
[SUCCESS] Magento_CustomerImportExport ... installed
[SUCCESS] Magento_DesignEditor ... installed
[SUCCESS] Magento_Dhl ... installed
[SUCCESS] Magento_Backend ... installed
[SUCCESS] Magento_Downloadable ... installed
[SUCCESS] Magento_CatalogInventory ... installed
[SUCCESS] Magento_Email ... installed
[SUCCESS] Magento_Fedex ... installed
[SUCCESS] Magento_Sales ... installed
[SUCCESS] Magento_Checkout ... installed
[SUCCESS] Magento_GoogleAnalytics ... installed
[SUCCESS] Magento_GoogleOptimizer ... installed
[SUCCESS] Magento_GoogleShopping ... installed
[SUCCESS] Magento_GroupedImportExport ... installed
[SUCCESS] Magento_GroupedProduct ... installed
[SUCCESS] Magento_ImportExport ... installed
[SUCCESS] Magento_Authorizenet ... installed
[SUCCESS] Magento_CatalogRule ... installed
[SUCCESS] Magento_Install ... installed
[SUCCESS] Magento_User ... installed
[SUCCESS] Magento_LayeredNavigation ... installed
[SUCCESS] Magento_Log ... installed
[SUCCESS] Magento_Multishipping ... installed
[SUCCESS] Magento_Newsletter ... installed
[SUCCESS] Magento_OfflinePayments ... installed
[SUCCESS] Magento_SalesRule ... installed
[SUCCESS] Magento_Ogone ... installed
[SUCCESS] Magento_PageCache ... installed
[SUCCESS] Magento_PayPalRecurringPayment ... installed
[SUCCESS] Magento_ConfigurableProduct ... installed
[SUCCESS] Magento_Paypal ... installed
[SUCCESS] Magento_Persistent ... installed
[SUCCESS] Magento_ProductAlert ... installed
[SUCCESS] Magento_RecurringPayment ... installed
[SUCCESS] Magento_Reports ... installed
[SUCCESS] Magento_RequireJs ... installed
[SUCCESS] Magento_Review ... installed
[SUCCESS] Magento_Rss ... installed
[SUCCESS] Magento_Captcha ... installed
[SUCCESS] Magento_Centinel ... installed
[SUCCESS] Magento_OfflineShipping ... installed
[SUCCESS] Magento_Sendfriend ... installed
[SUCCESS] Magento_Shipping ... installed
[SUCCESS] Magento_Sitemap ... installed
[SUCCESS] Magento_CatalogSearch ... installed
[SUCCESS] Magento_Tax ... installed
[SUCCESS] Magento_TaxImportExport ... installed
[SUCCESS] Magento_GoogleAdwords ... installed
[SUCCESS] Magento_Translation ... installed
[SUCCESS] Magento_Ups ... installed
[SUCCESS] Magento_GiftMessage ... installed
[SUCCESS] Magento_Integration ... installed
[SUCCESS] Magento_Usps ... installed
[SUCCESS] Magento_Webapi ... installed
[SUCCESS] Magento_Weee ... installed
[SUCCESS] Magento_CurrencySymbol ... installed
[SUCCESS] Magento_Wishlist ... installed
[SUCCESS] Artifact ... installed
@magicento magicento changed the title when i install at the last ,96% can not go on. when i install at the last ,96% continue. Sep 20, 2014
@magicento magicento changed the title when i install at the last ,96% continue. when i install at the last ,96% can not continue. Sep 20, 2014
@magicento magicento changed the title when i install at the last ,96% can not continue. when I install at the last ,96% can not continue. Sep 20, 2014
@magicento magicento changed the title when I install at the last ,96% can not continue. when I install at the last(Step 6: Install) ,96% can not continue. Sep 20, 2014
@tarikQT
Copy link

tarikQT commented Sep 20, 2014

response says installation finish
but screen stays on 96% with 500 error on response

if assume that install really finished
try to run
throws a expection file as follows

a:4:{i:0;s:73:"Looks like database is outdated. Please, use setup tool to perform update";i:1;s:2718:"#0 [internal function]: Magento\Framework\Module\Plugin\DbStatusValidator->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#1 /home/prices12/public_html/lib/internal/Magento/Framework/Interception/Chain/Chain.php(81): call_user_func_array(Array, Array)
#2 /home/prices12/public_html/lib/internal/Magento/Framework/Interception/Chain/Chain.php(76): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\Framewo...', 'dispatch', Object(Magento\Framework\App\FrontController\Interceptor), Array, 'front-controlle...')
#3 /home/prices12/public_html/app/code/Magento/PageCache/Model/App/FrontController/VarnishPlugin.php(79): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain{closure}(Object(Magento\Framework\App\Request\Http))
#4 [internal function]: Magento\PageCache\Model\App\FrontController\VarnishPlugin->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#5 /home/prices12/public_html/lib/internal/Magento/Framework/Interception/Chain/Chain.php(81): call_user_func_array(Array, Array)
#6 /home/prices12/public_html/var/generation/Magento/Framework/App/FrontController/Interceptor.php(88): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\Framewo...', 'dispatch', Object(Magento\Framework\App\FrontController\Interceptor), Array, 'front-controlle...')
#7 /home/prices12/public_html/app/code/Magento/PageCache/Model/App/FrontController/BuiltinPlugin.php(93): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\App\FrontController{closure}(Object(Magento\Framework\App\Request\Http))
#8 [internal function]: Magento\PageCache\Model\App\FrontController\BuiltinPlugin->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#9 /home/prices12/public_html/var/generation/Magento/Framework/App/FrontController/Interceptor.php(93): call_user_func_array(Array, Array)
#10 /home/prices12/public_html/var/generation/Magento/Framework/App/FrontController/Interceptor.php(115): Magento\Framework\App\FrontController\Interceptor->___call('dispatch', Array, Array)
#11 /home/prices12/public_html/lib/internal/Magento/Framework/App/Http.php(127): Magento\Framework\App\FrontController\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
#12 /home/prices12/public_html/lib/internal/Magento/Framework/App/Bootstrap.php(203): Magento\Framework\App\Http->launch()
#13 /home/prices12/public_html/index.php(39): Magento\Framework\App\Bootstrap->run(Object(Magento\Framework\App\Http))
#14 {main}";s:3:"url";s:1:"/";s:11:"script_name";s:10:"/index.php";}

@tzyganu
Copy link
Contributor

tzyganu commented Sep 20, 2014

The installation actually crashes.
I've said it here also: #668.
And it crashes when it tries to insert the admin account.
Because of this line:
$this->setup->getConnection()->insert($this->setup->getTable('admin_role'), $role, true);
from the Magento\Setup\Model\AdminAccount::save().
The table admin_role does not exist anymore. It is renamed to authorization_role in app/code/Magento/Authorization/sql/authorization_setup/install-1.0.0.0.php.

Now, why do you get 96%...Because of the strange formula used to calculate the progress.
Magento\Setup\Controller\Install\ProgressController::indexAction


        $moduleCount = count($this->moduleList->getModules());
        $log = $this->logger->get();
        $progress = 0;
        if (!empty($log)) {
            $progress = round(count($log)/$moduleCount*90);
        }
        $progress += 5;

So round(number-of-lines-inlog / module-count ) *90 + 5.
There are 80 modules + the line Artefact installed added "manually".
So you get round(81/80) * 90 + 5 = round(1.0125 * 90) + 5 = round(91.125) + 5 = 91 + 5 = 96.

Next issue...
The data update scripts should run after the admin is inserted. https://github.com/magento/magento2/blob/master/setup/module/Magento/Setup/src/Controller/Install/StartController.php#L179
By the way Magento Team...is it absolutely necessary to use exec? Looks ugly to me.

If you change in the line I mentioned above the table name from admin_role to authorization_role the install should work. But You still get Looks like database is outdated. because there are some modules that don't have install scripts but the data install script seams to pick them up.
Run this query UPDATE core_resource set version = data_version,
Now your Magento2-alpha96 should run nicely.

@tzyganu tzyganu mentioned this issue Sep 23, 2014
Closed
@verklov verklov added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 23, 2014
@verklov verklov self-assigned this Sep 23, 2014
@verklov
Copy link
Contributor

verklov commented Sep 23, 2014

All, we are aware of this issue and we are doing our best to get this fixed till the next deployment this Friday. Please be patient and wait till we deploy the code with the fix. Meanwhile, please use the console installation. Thank you all for reporting this!

@maksek maksek added the PS label Nov 12, 2014
@buskamuza
Copy link
Contributor

@zhangjiachao , @tzyganu , could you, please, confirm that these issues are gone (or still present) in the latest versions?

  1. installation stops at 96%
  2. issue with admin_role table
  3. application is not updated after installation and requests update ("Looks like database is outdated.")

P.S.: we're currently working on this issue with exec()

@tzyganu
Copy link
Contributor

tzyganu commented Nov 21, 2014

@buskamuza I can confirm that the installation does not stop anymore, I can also confirm that the admin saving process is not affected anymore by the admin_role table renaming and there is no more error message "Looks like database is outdated.".
I can also confirm that the install process does not take 2.3 eternities anymore. Just 1.2.
Last tested on alpha 104.
From my point of view, this issue can be closed.

magento-team pushed a commit that referenced this issue Oct 5, 2015
@dkvashninbay
Merge pull request #670 from magento-folks/totals-collector
5d35a7b 
[Folks] Collect totals logic optimization
mmansoor-magento pushed a commit that referenced this issue Dec 15, 2016
Merge pull request #670 from magento-mustang/new-PAT
2e22823 
[Mustangs] Performance Builds Restructurization - PAT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verklov verklov

Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@maksek @buskamuza @magicento @tarikQT @tzyganu @verklov @tanya-soroka