Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shipping and billing address ids not set on sales_invoice table for paypal express invoices #6438

Closed
maderlock opened this issue Sep 1, 2016 · 5 comments
Closed

shipping and billing address ids not set on sales_invoice table for paypal express invoices #6438

maderlock opened this issue Sep 1, 2016 · 5 comments
Labels
bug report Component: Sales Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@maderlock
Copy link

maderlock commented Sep 1, 2016 •
edited
Loading

Preconditions

  1. Magento 2.1.0, PHP 7, Mysql 5.7
  2. PayPal Express enabled

Steps to reproduce

  1. Put order through using PayPal Express
  2. Visit Invoice Grid
  3. Display columns billing name, shipping and billing addresses

Expected result

  1. These columns would be populated

Actual result

  1. These cells are blank for PayPal Express Payments
    screenshot 2016-09-01 12 05 36

Looking at the order address details, this information exists. So this is not an issue with the data not being retrieved from PayPal. I can see from the sales_invoice table, however, that the billing_address_id and shipping_address_id are null for PayPal Express orders.
@maderlock maderlock changed the title bill-to-name, shipping and billing address missing in invoice grid in admin shipping and billing address ids not set on sales_invoice table for paypal express invoices Sep 1, 2016
@maderlock maderlock mentioned this issue Sep 1, 2016
Closed
@maderlock
Copy link
Author

maderlock commented Sep 1, 2016 •
edited
Loading

It would appear that at the point of saving the invoice, there is no shipping or billing address available on the order itself, so it may be the order in which these things are being placed.

@alena-marchenko alena-marchenko self-assigned this Sep 1, 2016
@maderlock
Copy link
Author

As I don't want to dive in and work out the ordering of saving orders and invoices, for now I've added an observer to copy address information from the order to the invoice. Here are the important files from our Magento2fix module:
https://gist.github.com/maderlock/2b9a0f4f0badc10db66b9a74163d79b4

@dyushkin
Copy link
Contributor

dyushkin commented Sep 7, 2016

Hi @maderlock! Thank you for reporting, we've created internal ticket MAGETWO-58136 to fix it.

@dyushkin dyushkin added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Component: Sales labels Sep 7, 2016
mmansoor-magento pushed a commit that referenced this issue Sep 20, 2016
MAGETWO-58136: [Github] Shipping and billing address are not set if o…
4188149 
…rder placed with payment action Sale #6438
mmansoor-magento pushed a commit that referenced this issue Sep 20, 2016
MAGETWO-58136: [Github] Shipping and billing address are not set if o…
0194d4b 
…rder placed with payment action Sale #6438
mmansoor-magento pushed a commit that referenced this issue Sep 20, 2016
@VladimirZaets
Merge pull request #405 from magento-folks/bugs
a276241 
Bug
MAGETWO-56699 [GITHUB] Paypal checkout not possible with products that have custom options #5938 - for mainline
MAGETWO-58290 [Github]Empty product option is added on each PUT request #5963
MAGETWO-58136 [Github] Shipping and billing address are not set if order placed with payment action Sale #6438
MAGETWO-55608 [GITHUB] M2.1: Not scrollable picture on mobile / product page #5302
MAGETWO-58285 Ajax error message doesn't display in backend
MAGETWO-58338 [Github]Problem adding attribute options that start with a number via REST Api #5715
MAGETWO-52575 Unable to apply free shipping to specified method when creating order in admin
MAGETWO-57078 [GITHUB] Can't set customer group when creating a new order in the admin. #6162
MAGETWO-58039 Table rate shipping not applying correctly - for mainline
@SerhiyShkolyarenko
Copy link
Contributor

MAGETWO-58136 is delivered to develop branch. Closing the issue.

@Ctucker9233
Copy link

@SerhiyShkolyarenko What version of Magento is this in or is going to be in?

@YevSent YevSent mentioned this issue Apr 24, 2017
Closed
@pmclain pmclain mentioned this issue Apr 7, 2018
Closed
mmansoor-magento pushed a commit that referenced this issue May 11, 2021
@dvoskoboinikov
Merge pull request #6438 from magento-borg/2.3.7-bugfixes-120920
292e6d3 
[CIA] Bugfixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Component: Sales Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@maderlock @andimov @alena-marchenko @SerhiyShkolyarenko @dyushkin @Ctucker9233