SearchCriteriaBuilder builds wrong criteria (ORDER BY part)

[flancer64]

Empty SearchCriteria causes the error in \Magento\Framework\Data\Collection\AbstractDb::_setOrder
Target SQL has wrong ORDER BY clause (without any field inside):

SELECT ... ORDER BY  DESC

This is the code to get error:

class SalesRules
{
    /** @var \Magento\Framework\Api\Search\SearchCriteriaBuilder */
    protected $_builderSearchCriteria;
    /** @var \Magento\SalesRule\Api\RuleRepositoryInterface */
    protected $_repoRule;

    public function __construct(
        \Magento\Framework\Api\Search\SearchCriteriaBuilder $builderSearchCriteria,
        \Magento\SalesRule\Api\RuleRepositoryInterface $repoRule

    ) {
        $this->_builderSearchCriteria = $builderSearchCriteria;
        $this->_repoRule = $repoRule;
    }

    /**
     * Add sales rules.
     */
    public function init()
    {
        $crit = $this->_builderSearchCriteria->create();
        $all = $this->_repoRule->getList($crit);
    }
}

Method \Magento\SalesRule\Model\RuleRepository::getList adds order for $filed=null:

I suppose we need field validation in \Magento\Framework\Data\Collection\AbstractDb::_setOrder

private function _setOrder($field, $direction, $unshift = false)
{
    if($field) {
        ...
    }
    return $this;
}

or validation in the \Magento\SalesRule\Model\RuleRepository::getList:

    /** @var \Magento\Framework\Api\SortOrder $sortOrder */
    foreach ($sortOrders as $sortOrder) {
        $field = $sortOrder->getField();
        if($field) {
            $collection->addOrder(
                $field,
                ($sortOrder->getDirection() == SortOrder::SORT_ASC) ? 'ASC' : 'DESC'
            );
        }
    }

[flancer64]

These are the variables in the \Magento\SalesRule\Model\RuleRepository::getList:

[veloraven]

@flancer64 thank you for your report.
Please, provide the used version. If the problem is actual for a specific tag, please, specify it and be sure that the latest update was used.

[flancer64]

Magento ver. 2.1.0

[ishakhsuvarov]

Hi @flancer64
Issue seems to be fixed in 2.2-develop now and is going to be available in 2.2.4.
You may check the merge commit 506d500 which contains the fix.

Thank you.

[flancer64]

Thanks, great! :)