-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error page/maintenance page skin customisation is not currently possible #4305
Comments
Thank you for reporting, we have created MAGETWO-52323 to investigate and fix. |
Hi @mazhalai is there any update to this issue? |
@danny-balance still being investigated. |
…n is not currently possible #4305
…n is not currently possible #4305
This issue has been fixed and delivered to mainline. |
Hi, when will this be released? This was fixed in a commit 9 months ago and is still not in a release. |
@andimov |
@sshymko it will be included into 2.2 release version |
I have fixed it to change value of const ERROR_DIR in processor.php. |
Finished up by creating fake pub/pub/error/mymaintenance with readme inside. This also won't break when the fixed version will appear since it does not require any core updates. |
Be sure that your are in production mode. I wasn't able to see my custom in the developer mode. |
Still there in 2.1.10 Create the folder structure to fool the existence check
Note that you create a pub folder within the public folder public/pub/errors/ Your public folder can be public_html This error occurs when the magento2 folder is next to (or somewhere else then within) the public folder and you have symlinked the magento2/pub/* to public/ (and magento2/sitemap.xml to public/sitemap.xml etc.) |
Just checked 2.2-develop, and didn't see any updates in this regards that might indicate this has been fixed. |
@sankalp-prft: can you check the history of this file: https://github.com/magento/magento2/commits/2.2-develop/pub/errors/processor.php If you believe it still isn't fixed, feel free to provide steps to reproduce on a clean installation. |
[pangolins] MQE-1367: XSD schema validation error fixes
From what I can tell, the correct way to customise the default maintenance page is by adding a pub/errors/local.xml file & creating a new skin. It looks like there is a bug in this process.
In the
_setSkin
method inpub/errors/processor.php
it first checks if the directory exists before setting the config to use the custom skin:is_dir($this->_indexDir . self::ERROR_DIR . '/' . $value)
The problem lies in the variables setting up the path:
echo $this->_indexDir; // /var/www/src/pub/
echo self::ERROR_DIR; // pub/errors
Ending up with an incorrect path of:
/var/www/src/pub/pub/errors/custom_skin_name
It looks like either
$this->_indexDir
should be set to the Magento root (rather than the pub directory), or theERROR_DIR
const should not be prefixed with the pub dir.The text was updated successfully, but these errors were encountered: