Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElasticSearch When applying the extra filter to the product listing, Magento keeps the same page number #28011

Closed
santosh-gaggle opened this issue Apr 28, 2020 · 9 comments · Fixed by #28015
Closed

ElasticSearch When applying the extra filter to the product listing, Magento keeps the same page number #28011

santosh-gaggle opened this issue Apr 28, 2020 · 9 comments · Fixed by #28015
Assignees
@Bartlomiejsz
Labels
Component: Catalog Component: Swatches Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@santosh-gaggle
Copy link

santosh-gaggle commented Apr 28, 2020 •
edited by ihor-sviziev
Loading

ElasticSearch 6 filter issue

Preconditions (*)

  1. Magento 2.3.3
  2. PHP 7.2
  3. elasticsearch 6+

Steps to reproduce (*)

  1. Enter listing with n products,
  2. Move to the last page of results
  3. Select filter in the sidebar that filters out most of the products

Expected result (*)

1.I'm redirected either to last page of results or first page of the listing (so I see any products)

Actual result (*)

  1. I'm still at the last page of results before adding the filter, so the message says that there are no search results for my query

Here is the video: Desktop-2020-4-28-15-16-12.webm.zip
@m2-assistant
Copy link

m2-assistant bot commented Apr 28, 2020

Hi @santosh-gaggle. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@santosh-gaggle do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 28, 2020
@ihor-sviziev
Copy link
Contributor

Seems like might be fixed by #26988, but not sure

@santosh-gaggle
Copy link
Author

Seems like might be fixed by #26988, but not sure

checked but still the same issue

@lbajsarowicz
Copy link
Contributor

@ihor-sviziev No, because in my PR I fixed situation when you change amount of items on page, here it is about adding extra filters. And previously it was working by coincidence. Now, when Magento is expected to work properly with pagination - we need to address also that issue.

Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Apr 28, 2020
@Bartlomiejsz
Fix magento#28011 - remove page number from query on layered navigati…
92b29c6 
…on swatch filter
@Bartlomiejsz Bartlomiejsz mentioned this issue Apr 28, 2020
Merged
4 tasks
@ghost ghost assigned Bartlomiejsz Apr 28, 2020
@Bartlomiejsz
Copy link
Contributor

Bartlomiejsz commented Apr 28, 2020 •
edited
Loading

I created PR that fixes this case. Important here is that issue occurs only with swatch filter, same as color on video attached in description.

@ihor-sviziev ihor-sviziev self-assigned this Apr 28, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 28, 2020 •
edited by ihor-sviziev
Loading

Hi @ihor-sviziev. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@ihor-sviziev ihor-sviziev added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 28, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @ihor-sviziev
Thank you for verifying the issue. Based on the provided information internal tickets MC-33806 were created

Issue Available: @ihor-sviziev, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 28, 2020
@ihor-sviziev ihor-sviziev added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Apr 28, 2020
@santosh-gaggle
Copy link
Author

Thanks @Bartlomiejsz ,
Now this issue fixed and working well ...:)

@sdzhepa sdzhepa added Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Done Has been reviewed and prioritized during Triage with Product Managers and removed Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Apr 29, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jun 9, 2020
@magento-engcom-team
Copy link
Contributor

Hi @santosh-gaggle. Thank you for your report.
The issue has been fixed in #28015 by @Bartlomiejsz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

magento-engcom-team added a commit that referenced this issue Jun 9, 2020
@magento-engcom-team
ENGCOM-7493: Fix #28011 - remove page number from query on layered na…
fcdcc0e 
…vigation swatch filter #28015

 - Merge Pull Request #28015 from Bartlomiejsz/magento2:feature/fix_28011_page_number_on_swatch_layered_nav_filter
 - Merged commits:
   1. 92b29c6
   2. 475be33
   3. 7630cb0
   4. 0de77c8
   5. ee4acff
magento-engcom-team pushed a commit that referenced this issue Jun 9, 2020
@slavvka
ENGCOM-7493: Fix #28011 - remove page number from query on layered na…
249ce6d 
…vigation swatch filter #28015
@magento-engcom-team magento-engcom-team added the Reported on 2.3.3 Indicates original Magento version for the Issue report. label Nov 13, 2020
@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bartlomiejsz Bartlomiejsz

Labels
Component: Catalog Component: Swatches Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
Low Priority Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #28011 - remove page number from query on layered navigation swatch filter Bartlomiejsz/magento2
6 participants
@lbajsarowicz @ihor-sviziev @sdzhepa @Bartlomiejsz @magento-engcom-team @santosh-gaggle