Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipping Methods Don't Load In IE11 #22119

Closed
marshallthornton opened this issue Apr 2, 2019 · 22 comments
Closed

Shipping Methods Don't Load In IE11 #22119

marshallthornton opened this issue Apr 2, 2019 · 22 comments
Assignees
Labels
Component: Checkout Event: dmcdindia1 Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@marshallthornton
Copy link

Preconditions (*)

  1. Magento 2.3.1
  2. PHP 7.2
  3. IE11

Steps to reproduce (*)

  1. Add some items to the cart
  2. Go to checkout
  3. Enter in your address so that methods will load

Expected result (*)

  1. A list of shipping methods appear

Actual result (*)

  1. No methods load and the console shows the error: "SCRIPT438: Object doesn't support property or method 'entries'"

This error appears to have been introduced with the commit 4811ede which is using Object.entries to loop over the custom attributes of the address. However Object.entries is not supported in IE according to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries which is causing the error to get thrown and none of the methods to load. Magento still lists IE11 in the supported browsers so this should be fixed so that IE11 users can proceed through checkout.

@m2-assistant
Copy link

m2-assistant bot commented Apr 2, 2019

Hi @marshallthornton. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@marshallthornton do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 2, 2019
@ghost ghost self-assigned this Apr 4, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2019

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Checkout Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Fixed in 2.2.x The issue has been fixed in 2.2 release line good first issue Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 4, 2019
@ghost ghost removed their assignment Apr 4, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99043 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 4, 2019
@jayankaghosh
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @jayankaghosh. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @jayankaghosh, here is your Magento instance.
Admin access: https://i-22119-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@geet07
Copy link

geet07 commented Apr 23, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @geet07. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @geet07, here is your Magento instance.
Admin access: https://i-22119-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@dani97 dani97 self-assigned this May 3, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 3, 2019

Hi @dani97. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@dani97 dani97 removed their assignment May 4, 2019
@nittyy nittyy self-assigned this May 4, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @NithyaBabuKesavan. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@nittyy
Copy link

nittyy commented May 4, 2019

I am working on this at #dmcdindia19

nittyy pushed a commit to nittyy/magento2 that referenced this issue May 4, 2019
@alinalexandru
Copy link
Member

Apparently there exists a polyfill
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries#Polyfill

Can I create a pull request and add the polyfill into lib/web/mage/polyfill.js ?

@ghost ghost unassigned nittyy Sep 27, 2019
@magento-engcom-team magento-engcom-team removed the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Sep 30, 2019
@magento-engcom-team
Copy link
Contributor

Hi @marshallthornton.

Thank you for your report and collaboration!

The related internal Jira ticket MAGETWO-99043 was closed as non-reproducible in 2.3-develop.
It means that Magento team either unable to reproduce this issue using provided Steps to Reproduce from the Description section on clean Magento instance or the issue has been already fixed in the scope of other tasks.

But if you still run into this problem please update or provide additional information/steps/preconditions in the Description section and reopen this issue.

@magento-engcom-team magento-engcom-team added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Sep 30, 2019
@Styopchik
Copy link

I can confirm issue in IE11 on magento 2.3.2

@Styopchik Styopchik reopened this Oct 1, 2019
@ghost ghost removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed good first issue Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Oct 1, 2019
@sdzhepa
Copy link
Contributor

sdzhepa commented Oct 1, 2019

Hello @marshallthornton and @Styopchik

Thank you for contribution and collaboration!

Magento team has reconsidered this issue and related internal Jira ticket MAGETWO-99043 has been reopened.

Currently MAGETWO-99043 in progress and should be fixed and delivered soon. I will add updates here

@sdzhepa sdzhepa self-assigned this Oct 1, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 1, 2019

Hi @sdzhepa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@sdzhepa sdzhepa added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release and removed Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch labels Oct 1, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Oct 1, 2019
@magento-engcom-team
Copy link
Contributor

Hi @marshallthornton, @sdzhepa.

Thank you for your report and collaboration!

The issue was fixed by Magento team.

The fix will be available with the upcoming 2.3.4 release.

@sdzhepa
Copy link
Contributor

sdzhepa commented Oct 2, 2019

Hello @marshallthornton and @Styopchik

The issue was closed accidentally by mistake.
At this moment the internal Jira ticket MAGETWO-99043 is completed(Fixed/QA Passed) and waiting in the delivery queue.
I will update this Issue with commits info as soon as it will be delivered into public 2.3-develop branch

@sdzhepa sdzhepa reopened this Oct 2, 2019
@ghost ghost unassigned sdzhepa Oct 2, 2019
@ghost ghost removed the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Oct 2, 2019
@sdzhepa sdzhepa self-assigned this Oct 2, 2019
@magento-engcom-team
Copy link
Contributor

Hi @marshallthornton, @sdzhepa.

Thank you for your report and collaboration!

The issue was fixed by Magento team.

The fix will be available with the upcoming 2.3.4 release.

@JoostWan
Copy link

JoostWan commented Nov 6, 2019

@magento-engcom-team Can you share the commit where it's been fixed? Thanks!

@sdzhepa
Copy link
Contributor

sdzhepa commented Nov 6, 2019

Hello @JoostWan

As I can see the fix was delivered with the internal pull request in the scop of MAGETWO-99043
So, all related commits can be found using search and this number - LINK

Commit: c15e194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Checkout Event: dmcdindia1 Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

10 participants