Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DI compilation fails on class keyword #1722

Closed
shanethehat opened this issue Aug 21, 2015 · 2 comments
Closed

DI compilation fails on class keyword #1722

shanethehat opened this issue Aug 21, 2015 · 2 comments
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@shanethehat
Copy link

PHP 5.5 introduced the ability to use the class keyword to return the fully qualified class name of a class: http://php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class

When compiling the DI container, the setup module's PHPScanner tokenises PHP files that it finds, and upon discovering a T_CLASS token it attempts to capture the following class name and create a ReflectionClass object from it. In the case of Foo::class this fails, causing a reflection exception.

The PHPScanner needs to be modified so that it allows for this use of the class keyword.

@melnikovi
Copy link
Member

Internal ticket MAGETWO-41996

@joanhe joanhe added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development PS bug report labels Aug 24, 2015
@piotrekkaminski
Copy link
Contributor

This should be fixed now.

joanhe pushed a commit that referenced this issue Oct 21, 2015
…hant-beta

[Extensibility] MAGETWO-41996: [GitHub] DI compilation fails on class keyword #1722, MAGETWO-41792: Multiple stores at different paths rendering wrong store base_url
magento-team pushed a commit that referenced this issue Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

4 participants