Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magento admin gets in redirect loop when I login with a role that has no resources assigned #10611

Closed
kanduvisla opened this issue Aug 22, 2017 · 8 comments
Closed

Magento admin gets in redirect loop when I login with a role that has no resources assigned #10611

kanduvisla opened this issue Aug 22, 2017 · 8 comments
Assignees
@convenient
Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@kanduvisla
Copy link
Contributor

The Magento admin gets in redirect loop when I login with a role that has no resources assigned.

Preconditions

  1. Magento 2.1.7
  2. Chrome

Steps to reproduce

  1. Create a user role with no resources assigned to it.
  2. Create an admin user with that role.
  3. Log in with that user.

Expected result

I would expect a redirect back to the login page with a message or a page that shows an error message or warning.

Actual result

I get an ERR_TOO_MANY_REDIRECTS error in Chrome, insinuating that the page is in a redirect loop. The URL is: http://somedomain.dev/admin_1gqkv1/admin/noroute/denied/key/b6d4.../.
@magento-engcom-team magento-engcom-team added G1 Passed bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed and removed G1 Passed labels Sep 5, 2017
@okorshenko okorshenko added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 14, 2017
@lbajsarowicz
Copy link
Contributor

I've been debugging this issue and found out that if we add adminhtml/noroute/denied to public actions, this displays error page correctly:
zrzut ekranu z 2017-09-17 12-48-22

Need to go deeper if it won't cause any side effects. If not - I believe that will be enough solution for the issue.

@lbajsarowicz lbajsarowicz mentioned this issue Sep 17, 2017
Merged
@magento-engcom-team
Copy link
Contributor

@kanduvisla thank you for your bug report.
We've created internal ticket MAGETWO-75337 to track progress on the issue

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 19, 2017
magento-team pushed a commit that referenced this issue Sep 29, 2017
@ishakhsuvarov
MAGETWO-75326: #10611 Ignore request key check for error page to avoi…
b8086d2 
…d redirect loop #10921

 - Merge Pull Request #10921 from lbajsarowicz/magento2:bug/10611-redirect-loop
 - Merged commits:
   1. 2f422ad
magento-team pushed a commit that referenced this issue Sep 29, 2017
@vrann
MAGETWO-75326: #10611 Ignore request key check for error page to avoi…
a625680 
…d redirect loop #10921
raumatbel pushed a commit to raumatbel/magento2 that referenced this issue Sep 29, 2017
@raumatbel
magento#10611 Ignore request key check for error page to avoid redire…
6625945 
…ct loop
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-75326

@okorshenko
Copy link
Contributor

we need to backport the solution to 2.2-develop

@convenient
Copy link
Contributor

@okorshenko Should this one be a straight port of #10921 or the full fix as described by #10921 (comment) ?

If its the port i'll pick it up.

convenient added a commit to convenient/mtwo that referenced this issue Oct 4, 2017
@convenient
Disable secret key validation on admin noroute to fix redirect loop
ded7e67 
Similar to 2f422ad but using the framework.

Fixes issue magento#10611 for the `2.2-develop` branch.

Doesn't address the route cause, but only fixes the symptom as per magento#10921 (comment)
@convenient convenient mentioned this issue Oct 4, 2017
Merged
4 tasks
@okorshenko
Copy link
Contributor

Hi @convenient
We can accept a backport, but it would be great if you can provide full solution

@okorshenko
Copy link
Contributor

@kanduvisla thank you for your report. The issue is already fixed in 2.2-develop branch (PR: #11229 by @convenient ) and will be available in the Magento 2.2.2 release

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Oct 4, 2017
@vivek291186
Copy link

Nginx server still I am getting the same issue for redirect loop

PHP 7.1
Magento 2.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@convenient convenient

Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@kanduvisla @convenient @vivek291186 @magento-team @lbajsarowicz @okorshenko @vherasymenko @magento-engcom-team