Skip to content

Commit

Permalink
import-export-improvements #82 : configurable variations - not a supe…
Browse files Browse the repository at this point in the history
…r attribute error message improvements - travis ci build code style fixes
  • Loading branch information
Tadhg Bowe committed Jun 29, 2018
1 parent 7f9f6db commit a76e3a3
Showing 1 changed file with 3 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,7 @@ protected function _identifySuperAttributeError($superAttrCode, $rowNum)

if ($attributeRow['is_global'] !== '1') {
$codeNotGlobal = true;
}
elseif ($attributeRow['type'] !== 'select') {
} elseif ($attributeRow['type'] !== 'select') {
$codeNotTypeSelect = true;
}

Expand All @@ -354,12 +353,10 @@ protected function _identifySuperAttributeError($superAttrCode, $rowNum)
if ($codeExists == false) {
$this->_entityModel->addRowError(self::ERROR_ATTRIBUTE_CODE_DOES_NOT_EXIST, $rowNum, $superAttrCode);
$reasonFound = true;
}
elseif ($codeNotGlobal == true) {
} elseif ($codeNotGlobal == true) {
$this->_entityModel->addRowError(self::ERROR_ATTRIBUTE_CODE_NOT_GLOBAL_SCOPE, $rowNum, $superAttrCode);
$reasonFound = true;
}
elseif ($codeNotTypeSelect == true) {
} elseif ($codeNotTypeSelect == true) {
$this->_entityModel->addRowError(self::ERROR_ATTRIBUTE_CODE_NOT_TYPE_SELECT, $rowNum, $superAttrCode);
$reasonFound = true;
}
Expand Down

0 comments on commit a76e3a3

Please sign in to comment.