fix(inventory-catalog): don't join disabled products into collection

[damienwebdev]

Description (*)

MSI mistakenly conflates two situations as the same as a result of complex indexing behaviors.

1. When a product is disabled, it has no entry in the cataloginventory_stock_index or inventory_stock_*
2. When a product is not assigned to any sources, it has no entry in the cataloginventory_stock_index or inventory_stock_*

Fixed Issues (if relevant)

Currently, when computing the children of composite products like Bundles, Groups and Configurables, MSI will accidentally join in disabled children resulting in records with is_salable = NULL when adding stock data to a product collection.

This commit restores the original behavior.

This problem comes from @bubasuma in two separate commits

• e8d2ca7
• 17cf342

The commit e8d2ca7 attempts to allow products on category pages when the stock has no sources.

The second 17cf342 attempts to allow computing the lowest price of a configurable using only in stock products.

I'm specifically reverting part of 17cf342 but e8d2ca7 is also mistaken.

Likely, both of these commits need to be reverted and reworked to disambiguate "not in the stock index" from:

1. When a product is disabled
2. When a product is not assigned to any sources

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[paresh6002]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.