Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#26986 REST API Pagination issue #2840

Merged
merged 6 commits into from
Apr 10, 2020
Merged

#26986 REST API Pagination issue #2840

merged 6 commits into from
Apr 10, 2020

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Feb 23, 2020 •
edited
Loading

Description (*)

  1. Fixed currentPage to 1st page, related to magento/magento2 change.

Related Pull Requests

Fixed Issues (if relevant)

  1. REST API Pagination Does not work as expected magento2#26986

Manual testing scenarios (*)

N/A (API Functional Tests cover the change)

Questions or comments

Discussed on Slack and GitHub issue

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@lbajsarowicz lbajsarowicz mentioned this pull request Feb 23, 2020
Merged
4 tasks
@lbajsarowicz lbajsarowicz changed the title #26973 MSI Test working by coincidence (repeated 1st page on 2nd page) #26986 REST API Pagination issue Feb 23, 2020
@lenaorobei lenaorobei added the Auto-Tests: Covered All changes in Pull Request are covered by auto-tests label Mar 27, 2020
@magento-engcom-team magento-engcom-team merged commit 9290249 into magento:1.2-develop Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

Labels
Auto-Tests: Covered All changes in Pull Request are covered by auto-tests Award: bug fix Partner: Mediotype partners-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lbajsarowicz @ihor-sviziev @lenaorobei @magento-engcom-team @slavvka