Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on GitHub Actions #31

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Run tests on GitHub Actions #31

merged 1 commit into from
Aug 3, 2021

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Jul 27, 2021 •
edited
Loading

Here is a sample run from my repository:
image

https://github.com/ihor-sviziev/composer/actions/runs/1070971864

Note: there are failures on PHP 8 with lowest dependency, so I disabled running on it:
image
https://github.com/ihor-sviziev/composer/runs/3171104139?check_suite_focus=true

@ihor-sviziev ihor-sviziev changed the base branch from master to 1.8.x July 27, 2021 11:31
@fascinosum fascinosum changed the base branch from 1.8.x to develop July 30, 2021 03:03
fascinosum
fascinosum requested changes Jul 30, 2021
View reviewed changes
.github/workflows/php.yml Outdated Show resolved Hide resolved
@fascinosum
Copy link
Collaborator

hi @ihor-sviziev,
thank you for your contribution. Can I ask you update the feature branch (ihor-sviziev/composer@master...magento:develop) and attach the latest results of the builds?

@ihor-sviziev ihor-sviziev deleted the master branch August 2, 2021 05:47
@ihor-sviziev ihor-sviziev restored the master branch August 2, 2021 05:47
@ihor-sviziev ihor-sviziev reopened this Aug 2, 2021
@ihor-sviziev
Copy link
Contributor Author

ihor-sviziev commented Aug 2, 2021 •
edited
Loading

Hi @fascinosum,
I updated my PR with all changes from develop branch.

You can see the latest result here (note, this comment was updated after c7df3e3 was pushed):
https://github.com/ihor-sviziev/composer/pull/1/checks?check_run_id=3217688808
image

@fascinosum fascinosum self-requested a review August 3, 2021 02:57
@fascinosum fascinosum merged commit 044dc5b into magento:develop Aug 3, 2021
@fascinosum
Copy link
Collaborator

hi @ihor-sviziev,
thank you for your contribution to this project
First build results for this project: https://github.com/magento/composer/runs/3226937478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fascinosum fascinosum fascinosum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihor-sviziev @fascinosum