This repository has been archived by the owner on Apr 16, 2020. It is now read-only.
BREAKING: Use path as URL instead of /resize/:width/:height #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zetlen
pushed a commit
to magento/pwa-studio
that referenced
this pull request
Oct 3, 2019
The express-sharp library has updated to v3.0.0, which includes a [breaking change](magento-research/express-sharp#5) to the URL scheme, and therefore the public API of the library. This helps us simplify the code in addImgOptMiddleware, because we don't have to rewrite the URL as aggressively--it's closer to the Fastly paradigm. Closes #1808, and some other issues.
zetlen
pushed a commit
to magento/pwa-studio
that referenced
this pull request
Oct 3, 2019
The express-sharp library has updated to v3.0.0, which includes a [breaking change](magento-research/express-sharp#5) to the URL scheme, and therefore the public API of the library. This helps us simplify the code in addImgOptMiddleware, because we don't have to rewrite the URL as aggressively--it's closer to the Fastly paradigm. Closes #1808, and some other issues.
zetlen
pushed a commit
to magento/pwa-studio
that referenced
this pull request
Oct 4, 2019
The express-sharp library has updated to v3.0.0, which includes a [breaking change](magento-research/express-sharp#5) to the URL scheme, and therefore the public API of the library. This helps us simplify the code in addImgOptMiddleware, because we don't have to rewrite the URL as aggressively--it's closer to the Fastly paradigm. Closes #1808, and some other issues. test: coverage for addImgOptMiddleware changes
zetlen
pushed a commit
to magento/pwa-studio
that referenced
this pull request
Oct 4, 2019
The express-sharp library has updated to v3.0.0, which includes a [breaking change](magento-research/express-sharp#5) to the URL scheme, and therefore the public API of the library. This helps us simplify the code in addImgOptMiddleware, because we don't have to rewrite the URL as aggressively--it's closer to the Fastly paradigm. Closes #1808, and some other issues. test: coverage for addImgOptMiddleware changes
zetlen
pushed a commit
to magento/pwa-studio
that referenced
this pull request
Oct 7, 2019
The express-sharp library has updated to v3.0.0, which includes a [breaking change](magento-research/express-sharp#5) to the URL scheme, and therefore the public API of the library. This helps us simplify the code in addImgOptMiddleware, because we don't have to rewrite the URL as aggressively--it's closer to the Fastly paradigm. Closes #1808, and some other issues. test: coverage for addImgOptMiddleware changes
dpatil-magento
pushed a commit
to magento/pwa-studio
that referenced
this pull request
Oct 10, 2019
* feat: Simplify image middleware with express-sharp update The express-sharp library has updated to v3.0.0, which includes a [breaking change](magento-research/express-sharp#5) to the URL scheme, and therefore the public API of the library. This helps us simplify the code in addImgOptMiddleware, because we don't have to rewrite the URL as aggressively--it's closer to the Fastly paradigm. Closes #1808, and some other issues. test: coverage for addImgOptMiddleware changes * fix: WebP content negotiation. Closes #1842 * fixup prettier
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to an API closer to Sharp's parameters.
/resize/480are nonintuitive and defeat a lot of cache mechanisms.