Eliminate usage of Zend_Mail from Magento 2 Open Source #136
Conversation
|
|
|
|
| @@ -71,18 +71,18 @@ protected function mockModel($filesystem = null) | |||
|
|
|||
| $this->objectManager->get(\Magento\Framework\App\State::class)->setAreaCode('frontend'); | |||
|
|
|||
| $this->model->expects($this->any())->method('_getMail')->will($this->returnCallback([$this, 'getMail'])); | |||
| $this->model->expects($this->any())->method('_getMail')->will($this->returnCallback([$this, 'getMessage'])); | |||
There was a problem hiding this comment.
Looks like _getMail() method doesn't exist anymore. It shouldn't be necessary here then.
There was a problem hiding this comment.
Thank you @buskamuza for catching this, I overlooked it. Will fix it asap.
This test seems to be obsolete, am I right?
There was a problem hiding this comment.
Hm... probably the test itself still makes some sense. But anything related to $this->mail does not.
|
Hi @buskamuza I adapted the test, it seems that |
|
Hi @buskamuza anything else I can do which helps in processing this PR? |
Description
all references to Zend_Mail are removed from Magento 2 Open Source
added static a test that verifies that Zend_Mail is not used
Travis builds are green on PHP 7.1 environment, see: https://travis-ci.org/mhauri/php-7.2-support/builds/386828793
all backward incompatible changes are documented (if any)if ZF1 component replaced by ZF2 component:
See: Replace Zend_Mail (ZF1) with Zend\Mail (ZF2) magento/magento2#8608
Fixed Issues (if relevant)
Contribution checklist