resolves #4 : QA Pipeline #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidLambauer
force-pushed
the
2.4-develop
branch
from
969cec7
to
2425012
Compare
Vinai
reviewed
Nov 21, 2022
| @@ -56,4 +56,9 @@ public function __construct( | |||
|
|
|||
| $this->_openActions[] = ImsCallback::ACTION_NAME; | |||
| } | |||
|
|
|||
| private function unusedMethod() | |||
There was a problem hiding this comment.
What is the purpose of this method? Left over debug code?
There was a problem hiding this comment.
Can be seen so, yes. I want to execute PHPMD only on the changed files within a PR to speed up the process. To test this behavior, I need a PHPMD error :). Can be removed as soon as I've seen the result and the nightly builds run again.
DavidLambauer
force-pushed
the
2.4-develop
branch
from
c0c02c5
to
be35899
Compare
DavidLambauer
changed the title
DavidLambauer
changed the title
DavidLambauer
changed the title
DavidLambauer
changed the title
Switched to bin/magento execution WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions Replaced tests:run with native phpmd Changed Output Format to GitHub Fixed scope WIP - Working on Github Actions WIP - Working on Github Actions run only for changed files and PRs WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions wip Changed matrix to latest Back to currently-supported as latest doesnt work Used a custom step to get changed files fixed my mess syntax changed action for changed files WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions
DavidLambauer
force-pushed
the
2.4-develop
branch
from
d51f52b
to
d9d8e94
Compare
|
That finally seem to work as expected for PHPMD.
|
|
@DavidLambauer is this PR still a work-in-progress? |
|
Yeh, I'll work on it. As we now have the GitHub Actions Repo, I'll transfer everything to there and push an action for PHPMD |
|
Will move this to the github actions repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a QA Workflow that uses a Matrix to spin up the same jobs with different parameters. Right now, the matrix is set to
supported-versions, equivalent to Adobe's support lifecycle. I assume the matrix will change, but to me, it makes sense to have the option to test a PR against different variations of dependencies.For now, the only test that runs is PHPMD. I used the Magento Ruleset. A complete run of PHPMD for all Magento Extensions takes around an hour, which is way too long. I only run PHPMD on the changed files within a PR to speed up the feedback loop. This works great for
stupidtools like PHPMD and PHPCS, but it might not be possible for PHPStan, Copy/Paste Detector, or similar tools.As the current full scan of PHPMD on Magento throws a lot of errors, I assume I messed up some parameters, or Magento works with a baseline. I haven't found one, so I assume this potential baseline is internal. We should discuss that baseline topic in a tech meeting.
The command to run PHPMD:
php vendor/bin/phpmd app/code github dev/tests/static/testsuite/Magento/Test/Php/_files/phpmd/ruleset.xmlfixes #4