Skip to content

Commit

Permalink
Improve "detected inconsistent lock order" error message
Browse files Browse the repository at this point in the history
  • Loading branch information
hebasto committed Jun 25, 2020
1 parent bbe9cf4 commit 0ecff9d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/sync.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ struct CLockLocation {
std::string ToString() const
{
return strprintf(
"%s %s:%s%s (in thread %s)",
"'%s' in %s:%s%s (in thread '%s')",
mutexName, sourceFile, sourceLine, (fTry ? " (TRY)" : ""), m_thread_name);
}

Expand Down Expand Up @@ -129,7 +129,7 @@ static void potential_deadlock_detected(const LockPair& mismatch, const LockStac
LogPrintf(" %s\n", i.second.ToString());
}
if (g_debug_lockorder_abort) {
tfm::format(std::cerr, "Assertion failed: detected inconsistent lock order at %s:%i, details in debug log.\n", __FILE__, __LINE__);
tfm::format(std::cerr, "Assertion failed: detected inconsistent lock order for %s, details in debug log.\n", s2.back().second.ToString());
abort();
}
throw std::logic_error(strprintf("potential deadlock detected: %s -> %s -> %s", mutex_b, mutex_a, mutex_b));
Expand Down

0 comments on commit 0ecff9d

Please sign in to comment.