Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play with DLNA #226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Play with DLNA #226

wants to merge 1 commit into from

Conversation

apelike
Copy link

@apelike apelike commented Aug 23, 2015

Mostly ripped from Popcorn Time

@apelike apelike force-pushed the dlna branch 2 times, most recently from 0624ac9 to 3ad1359 Compare August 24, 2015 01:39
@watdafox
Copy link

Our work on DLNA is still pretty bad, we use heavily modified version of nodecast-js and it mostly... well, works on a few TVs but not that much. I'm no specialist of the DLNA, so maybe this PR makes sense, but I would advise to test & make sure it's working.

In Popcorn Time, as we're not a node_module, we can affort to have hackish semi-working things, but peerflix is another story^^

@apelike
Copy link
Author

apelike commented Aug 27, 2015

I see. It seems to work flawlessly with my Xbox One, but that's all I've been able to test. I welcome more testers to give it a shot and hack it to get it working. Even If it only works on some devices, merging this would at least pave the way for contributions to improve support.

Nodecast definitely doesn't seem to work out of the box with the default options available, which is inconvenient to say the least. Has popcorn thought to submit their work to nodecast-js as a PR?

As a sidenote, it would be nice if peerflix extracted each player into a dedicated module function. I think that would make it more useful to other libraries and maybe make the addition of plugins possible.

@mafintosh
Copy link
Owner

@apelike extracting the playere is a great idea. we should definitely do that. doee any of these new deps require native compiling?

@apelike
Copy link
Author

apelike commented Nov 10, 2015

Sorry for the lack of communication. I don't believe any of the modules require native compiling.

Also, I just rebased w/ master.

@qarkai
Copy link

qarkai commented Sep 12, 2020

Rebased on current master and got:

peerflix/app.js:378
          if (err) throw err
                   ^

Error: Invalid Args (402)
    at peerflix/node_modules/upnp-mediarenderer-client/node_modules/upnp-device-client/index.js:141:21
    at ConcatStream.<anonymous> (peerflix/node_modules/concat-stream/index.js:37:43)
    at ConcatStream.emit (events.js:326:22)
    at finishMaybe (peerflix/node_modules/readable-stream/lib/_stream_writable.js:630:14)
    at endWritable (peerflix/node_modules/readable-stream/lib/_stream_writable.js:638:3)
    at ConcatStream.Writable.end (peerflix/node_modules/readable-stream/lib/_stream_writable.js:594:41)
    at IncomingMessage.onend (_stream_readable.js:682:10)
    at Object.onceWrapper (events.js:420:28)
    at IncomingMessage.emit (events.js:326:22)
    at endReadableNT (_stream_readable.js:1252:12) {
  code: 'EUPNP',
  statusCode: 500,
  errorCode: '402'
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants