-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play with DLNA #226
base: master
Are you sure you want to change the base?
Play with DLNA #226
Conversation
0624ac9
to
3ad1359
Compare
Our work on DLNA is still pretty bad, we use heavily modified version of nodecast-js and it mostly... well, works on a few TVs but not that much. I'm no specialist of the DLNA, so maybe this PR makes sense, but I would advise to test & make sure it's working. In Popcorn Time, as we're not a node_module, we can affort to have hackish semi-working things, but peerflix is another story^^ |
I see. It seems to work flawlessly with my Xbox One, but that's all I've been able to test. I welcome more testers to give it a shot and hack it to get it working. Even If it only works on some devices, merging this would at least pave the way for contributions to improve support. Nodecast definitely doesn't seem to work out of the box with the default options available, which is inconvenient to say the least. Has popcorn thought to submit their work to nodecast-js as a PR? As a sidenote, it would be nice if peerflix extracted each player into a dedicated module function. I think that would make it more useful to other libraries and maybe make the addition of plugins possible. |
@apelike extracting the playere is a great idea. we should definitely do that. doee any of these new deps require native compiling? |
Sorry for the lack of communication. I don't believe any of the modules require native compiling. Also, I just rebased w/ master. |
Rebased on current master and got:
|
Mostly ripped from Popcorn Time