[KAPP-175] Staff Dashboards #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Impac configuration to be changed at runtime.
cesar-tonnoir
approved these changes
Mar 28, 2019
adamaziz15
approved these changes
Mar 29, 2019
Required changes have been released in 1.8.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This feature allow staff to create their own dashboards to view their customer data from the admin panel.
The dashboard are owned by the staff but use the customer company as data source.
Technical details
The main difficulty was to have two different modes for Impac:
This is possible through the
ImpacConfigSvcwhich reconfigures impac-angular at runtime (see maestrano/impac-angular#565)Note that we use the same
ImpacControllerto display templates and staff dashboard so this is controlled via state data.On the UI side, there's a new
mnoe-staff-dashboard-listcomponent, which just display the list of staff dashboards.impac-angular was updated to 1.8 to have the latest features (notably the templates).
I've noted that I'll need to implement the feature flag in the backend as well.
Screenshots
Staff Dashboard List
Create a new staff dashboard
Staff Dashboard view