[KAPP-175] Improve dashboard templates #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use built-in MnoeConfirm component rather than a custom modal.
ouranos
force-pushed
the
feature/improve-dashboard-templates
branch
from
26498df
to
6e4412c
Compare
Do not activate routes if the dashboard designed is not enabled.
ouranos
force-pushed
the
feature/improve-dashboard-templates
branch
from
6e4412c
to
03cf63a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the upcoming staff dashboard PR, I've improved a bit the dashboard templates:
MnoeConfirminstead of and individual modal(I've also merged
1.0in master in preparation for a1.1branch and tag)