Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNOE-795] Refresh messages page when changing organizations #383

Merged

Conversation

adamaziz15
Copy link
Contributor

@ouranos @x4d3 @alexnoox Ready for review 👍

Copy link
Contributor

@alexnoox alexnoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please just re-order the DI services.

@@ -2,7 +2,7 @@ angular.module('mnoEnterpriseAngular').component('mnoeTasks', {
bindings: {
},
templateUrl: 'app/components/mnoe-tasks/mnoe-tasks.html',
controller: ($filter, $uibModal, $translate, $timeout, $q, toastr, MnoErrorsHandler, MnoeTasks, MnoeCurrentUser)->
controller: ($filter, $scope, MnoeOrganizations, $uibModal, $translate, $timeout, $q, toastr, MnoErrorsHandler, MnoeTasks, MnoeCurrentUser)->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

($filter, $scope, $uibModal, $translate, $timeout, $q, toast, MnoeOrganizations, MnoeTasks, MnoeCurrentUser, MnoErrorsHandler)

@adamaziz15
Copy link
Contributor Author

@alexnoox dependencies re-ordered :)

@ouranos
Copy link
Contributor

ouranos commented Nov 28, 2017

@xaun @x4d3 can one of you review? Thanks

@alexnoox alexnoox merged commit df4694d into maestrano:feature/tasks Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants