[APPINT-1146] Fix database encoding configuration #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouranos
requested review from
alachaum,
hhemanth,
xiuzhong,
adamaziz15,
paulstuartparker and
alexmaestrano
|
Here's how it looks like: |
Sometimes the database is created with an character set different that the one specified in `config/database.yml`. This causes some issue when the database is created in non utf8 charset (eg: latin1). This commit adds an initializer that warn the user in case of mismatch between the configured and actual encoding. It also provides a migration generator to facilitate charset migration.
ouranos
force-pushed
the
feature/fix-db-encoding
branch
from
cc23003
to
eb81358
Compare
hhemanth
approved these changes
Nov 2, 2018
adamaziz15
approved these changes
Nov 2, 2018
alexmaestrano
approved these changes
Nov 2, 2018
|
@alexmaestrano Yes we'll have to update the gem and then use the generator to create the migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the database is created with an character set different that
the one specified in
config/database.yml.This causes some issue when the database is created in non utf8 charset
(eg: latin1).
This commit adds an initializer that warn the user in case of mismatch
between the configured and actual encoding.
It also provides a migration generator to facilitate charset migration.