Skip to content

Commit

Permalink
feat: add missing hardcoded localization
Browse files Browse the repository at this point in the history
  • Loading branch information
maelchiotti committed Apr 12, 2024
1 parent ec2f5b6 commit 2c39105
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ In order to improve or add support for a language, please follow these steps:

- Localized strings can be found in two different places:
- The `app_XX.arb` file located in [`lib/l10n`](lib/l10n) (where `XX` corresponds to the language code), that contains the vast majority of all strings. Please make sure that you do not localize any parameter name (ex: `{parameter}`) and that you do escape single quotes (ex: `I''m ok` instead of `I'm ok`).
- The [`harcoded_localizations.dart`](lib/l10n/harcoded_localizations.dart), that contains a few specific strings that need to be hardcoded.
- The [`hardcoded_localizations.dart`](lib/l10n/hardcoded_localizations.dart), that contains a few specific strings that need to be hardcoded.
- Localized strings can be generated with the `flutter gen-l10n` command. Check that the [`unstranslated.txt`](lib/l10n/untranslated.txt) file is empty, otherwise it will indicate which strings you did not translate.
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Note get welcomeNote {
title = 'Bienvenue dans $_appName !';
content = 'Notes simples, locales, en material design';
} else if (locale == SupportedLocalizations.turkish.locale) {
title = '';
title = "$_appName'a hoşgeldin!";
content = 'Basit, çevrimdışı, materyal tasarımlı notlar';
} else {
log('Missing welcome note strings for locale: $locale');
Expand Down
2 changes: 1 addition & 1 deletion lib/utils/database_manager.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import 'dart:typed_data';

import 'package:is_first_run/is_first_run.dart';
import 'package:isar/isar.dart';
import 'package:localmaterialnotes/l10n/harcoded_localizations.dart';
import 'package:localmaterialnotes/l10n/hardcoded_localizations.dart';
import 'package:localmaterialnotes/models/note/note.dart';
import 'package:localmaterialnotes/utils/constants/constants.dart';
import 'package:localmaterialnotes/utils/extensions/date_time_extensions.dart';
Expand Down
2 changes: 1 addition & 1 deletion lib/utils/quick_actions_manager.dart
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import 'package:flutter/cupertino.dart';
import 'package:flutter_riverpod/flutter_riverpod.dart';
import 'package:localmaterialnotes/common/actions/add.dart';
import 'package:localmaterialnotes/l10n/harcoded_localizations.dart';
import 'package:localmaterialnotes/l10n/hardcoded_localizations.dart';
import 'package:quick_actions/quick_actions.dart';

class QuickActionsManager {
Expand Down

0 comments on commit 2c39105

Please sign in to comment.