update: port to PostCSS 8. #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludofischer
commented
Nov 20, 2020
| await postcss([...pluginList, parser.plugin]).process(css, { | ||
| from: inputFile, | ||
| }); | ||
| await postcss([...pluginList, parser.plugin]).process(css, { |
There was a problem hiding this comment.
Should this be the entry point instead of running inside Once()?
|
@ludofischer thanks a lot for working on this! I actually just saw this after I submitted #114 which passes all the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since people are want to get the vue compiler to work with PostCSS 8 (vuejs/core#2649) and the vue compiler uses postcss-modules, it might be useful to port postcss-modules to PostCSS 8 to so that Vue only requires PostCSS 8.
I have made this a draft because I haven't tested whether invoking
postcss()again inside the plugin will play well with the PostCSS 8 single-tree traversal. Will other plugins be notified of the changes? Do we care? Should this implement the Processor interface instead?