Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with the version-script (
zlib.map
) when also building with enabledz_
prefix for the function names.Without the changes from this PR the version-script did not properly assign version numbers to the function symbols in
zlib.so
(using GCC or Clang) if the function symbols are prefixed withz_
!Background
Most linkers silently ignored this error and just generated a
zlib.so
without any version numbers attached. Starting withlld
17 (or was it 16?), however, linking even fails with the following errors:The reason is that
zlib.map
did not care whether thez_
prefix is used or not.