Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-346: Fix unlock after minimize #731

Merged
merged 8 commits into from
Jan 30, 2023

Conversation

alex-tsx
Copy link
Collaborator

  • [tech] Fix postinstall script on Linux
  • TW-346: Fix unlock after minimize. With bootsplash screen hiding earlier
  • TW-346: Fix unlock after minimize. With disabling 'warm-up' in 'react-native-keychain'

@alex-tsx alex-tsx requested a review from unixvb January 19, 2023 07:32
@alex-tsx
Copy link
Collaborator Author

alex-tsx commented Jan 19, 2023

It seems that the issue lies entirely with user minimizing the app, when runtime entered Keychain.getGenericPassword but hasn't returned yet.

So the strategy to solve it was reducing the execution time of this method by installing react-native-keychain manually without warm-up mechanism:

See report of our particular behavior:

Useful links:

Some alternatives worth looking into:

src/app/app.tsx Outdated Show resolved Hide resolved
@alex-tsx alex-tsx requested a review from unixvb January 23, 2023 11:52
@tttt24 tttt24 temporarily deployed to fastlane January 24, 2023 09:03 — with GitHub Actions Inactive
@unixvb unixvb merged commit c33d784 into development Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants