Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax rails dependency to support Rails 5 #52

Merged
merged 1 commit into from
Jul 8, 2016
Merged

Relax rails dependency to support Rails 5 #52

merged 1 commit into from
Jul 8, 2016

Conversation

cbeer
Copy link
Contributor

@cbeer cbeer commented Jul 8, 2016

No description provided.

@cbeer cbeer mentioned this pull request Jul 8, 2016
Closed
5 tasks
@cbeer
Copy link
Contributor Author

cbeer commented Jul 8, 2016

The build failure appears unrelated; I've submitted either #53 or #54 to try to fix the dependency problem.

@lukaszsagol
Copy link
Contributor

🚀

Thank you very much for this one and Travis config changes.

Hope this will speed up your upgrade to Rails 5 :)

@lukaszsagol lukaszsagol merged commit 780f1c4 into madebymany:master Jul 8, 2016
@cbeer cbeer deleted the rails5 branch July 8, 2016 17:32
@cbeer
Copy link
Contributor Author

cbeer commented Jul 8, 2016

@lukaszsagol thanks for merging -- any chance of a 0.5.1 release with the relaxed dependency?

@lukaszsagol
Copy link
Contributor

@cbeer https://rubygems.org/gems/sir_trevor_rails/versions/0.5.1 :shipit:

@cbeer
Copy link
Contributor Author

cbeer commented Jul 8, 2016

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbeer @lukaszsagol