Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use default tags on an aws provider level #336

Merged
merged 5 commits into from
Jun 10, 2023
Merged

use default tags on an aws provider level #336

merged 5 commits into from
Jun 10, 2023

Conversation

mglotov
Copy link
Contributor

@mglotov mglotov commented Jun 9, 2023

PR Description

  • Set default tags on a provider level. It automatically tags all created resources even if tags aren't set on a resource level. Link to doc on how it works.
  • Updated aws provider to the latest version because of the issue
  • Deleted a aws_s3_bucket_acl.cloudtrail resource because newly created buckets don't support ACLs
  • Added a new aws-cost-allocation-tags module. It enables collecting cost usage to specified tags. KEEP IN MIND, it works only for a payer account.
  • Fixed a deprecation warning for a module.pritunl.aws_eip.this resouce

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

p1gmale0n
p1gmale0n previously approved these changes Jun 9, 2023
@mglotov mglotov requested a review from a team June 9, 2023 11:32
khalezin
khalezin previously approved these changes Jun 9, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mglotov mglotov changed the title Default tags use default tags on an aws provider level Jun 9, 2023
@mglotov mglotov requested review from p1gmale0n, khalezin and a team June 9, 2023 11:47
@mglotov mglotov merged commit 661ed65 into main Jun 10, 2023
@mglotov mglotov deleted the default-tags branch June 10, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants