Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: do not use terraform modules for deploying aws-load-balancer-controller #160

Merged
merged 2 commits into from
Nov 5, 2021
Merged

enh: do not use terraform modules for deploying aws-load-balancer-controller #160

merged 2 commits into from
Nov 5, 2021

Conversation

mglotov
Copy link
Contributor

@mglotov mglotov commented Nov 4, 2021

PR Description

Please explain the changes you made here and link to any relevant issues.

Fixes #139

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@mglotov mglotov requested review from halfb00t, p1gmale0n, khalezin and a team November 4, 2021 11:33
@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mglotov mglotov merged commit 87e5657 into main Nov 5, 2021
@mglotov mglotov deleted the enh/aws-load-balancer-controller branch November 15, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p1gmale0n p1gmale0n p1gmale0n approved these changes

@halfb00t halfb00t halfb00t approved these changes

@khalezin khalezin Awaiting requested review from khalezin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws-load-balancer-controller]: Switch from using terraform module to raw resources
3 participants
@mglotov @p1gmale0n @halfb00t