-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken with Knockout 2.1.0 #6
Comments
Ya, I really like the structure behind this project...but it looks like it's dead :(. I might try to fork it and go off with my own set. |
What would be involved in bringing this project back to life? My team might be interested in taking it on, depending on the level of effort to get it compatible with ko 2.1.0. |
Hi All, I've been meaning to get back to this project and complete a rewrite and get everything working with 2.1 but have been super busy with new job etc. I actually more or less completed a rewritten version of the tabs component which I was using as a starter for the other components. I'll try and devote most of this weekend to it and see what I can get done. I'll aim to get the new version out in the next two weekends. The new version includes
That being said. I would also love some help maintaining the project in the future so I'd be happy to add anyone that would like to contribute. Thanks, Ian |
I'm kind of in the same boat with the job thing, but I'd love to help out. I'll see what I can do to get involved. It's a great project with some really interesting control concepts. On Aug 8, 2012, at 10:54 AM, Ian Mckay [email protected] wrote:
|
My team might be interested in helping out. Our company builds knockout
|
I'm not even sure how these open source projects work :P. I may not be able I've got a combobox control that I've been working on at the office which Keep me in the loop and I'll see what I can do. FYI, I'm in Phoenix, AZ (which has it's own timezone essentially). Also, I I'm also getting pretty experienced with NuGet packages should we decide to Farina On Wed, Aug 8, 2012 at 12:31 PM, Byron Sommardahl
|
@bsommardahl - I'd love to get your input. I'd prefer to do it a week this Saturday, just because I can guarantee my schedule this weekend and I should also have reworked a number of the components by then. Other than the obvious 2.1 compatibility were there any other features, issues you had experienced? I've been putting off, incorrectly, minor maintenance because of my desire to rewrite the code. I've now become a 100% js engineer for the last 12 months so I know I can improve what was a decent but not spectacular code base. Where necessary I'm aiming to add jasmine tests, proper modularization and full jshint passing code. I was thinking after I've pushed the new version I can add you all as contributors so you can accept pull requests. Having not collaborated on github I'm not sure what the best way to expose my dev branch to you guys earlier, any ideas? If I can do that you can get hold and critic the code before the big push. This will be a breaking change so the old code will be grandfathered into a sub directory. I'm aiming to eliminate the legacy jquery template lib and as much of jqueryui as possible. I'd also like to touch optimize the controls but I think that will wait till after next push. |
Any chance you can push your progress to github as you are working on it? On Wed, Aug 8, 2012 at 7:22 PM, Ian Mckay [email protected] wrote:
|
I would like to avoid pushing incomplete versions especially since its would involve reorganizing and breaking existing components. I should be able to fix up the tree to work with 2.1. Shouldn't be too much wrong with it. What errors are you getting? Do you know of any best practice for collaborating on github for major rewrites? Locally I can have a dev branch etc. Would it make sense to fork my own repo as V2. Work on that then merge back into the original and delete the fork? |
I would definitely check in your branch so that the branch is visible on I forget the errors we were getting. Part of them had to do with On 08/08/2012, at 20:10, Ian Mckay [email protected] wrote: I would like to avoid pushing incomplete versions especially since its I should be able to fix up the tree to work with 2.1. Shouldn't be too much Do you know of any best practice for collaborating on github for major — |
OK great. I'll take a look tonight. If I recall KO 2.1 requires a certain On Thu, Aug 9, 2012 at 3:28 PM, Byron Sommardahl
|
Are you still planning to use jQuery tmpl for KOUI? I'd just assume pull it Farina On Thu, Aug 9, 2012 at 3:35 PM, Ian Mckay [email protected] wrote:
|
I'm definitely planning on removing it in the coming version. Byron needs On Thu, Aug 9, 2012 at 4:29 PM, Mark Farina, Jr.
|
We use KO's native templates. On Thu, Aug 9, 2012 at 5:29 PM, Mark Farina, Jr.
|
That's the issue i'm afraid. The current tree won't work without jquery tmpl, it was written almost a year before native templates came out. I got a prototype rewritten tree completed this weekend. The tree if by far the most complicated component so the others should follow along nicely. It's currently 50% of the size of the original :) Drag and drop still to redo. |
Very cool. We went ahead and implemented something quick and ugly to show On Mon, Aug 13, 2012 at 3:24 PM, Ian Mckay [email protected] wrote:
|
Any progress on this? |
I'll be honest, I've done absolutely nothing since the last email :(. I've Farina On Tue, Sep 4, 2012 at 3:12 AM, doctea [email protected] wrote:
|
I finished the rewrite for the tree and tabs. I can push what I have to the dev branch today. I just need to get the other controls converted and then get to grips with creating some github pages to show the examples. It's taking longer than expected as I haven't had the time to work on it at a weekend yet. |
Hey @madcapnmckay, did you manage to push the changes for the tree you had worked on? |
Just stumbled across this. I'd also be interested in having a play with the new 2.x versions if you have them @madcapnmckay |
Hi, would also like to use test the 2.x versions @madcapnmckay ... Thanks! |
Same here. Would be interested in the KO 2.x development version, @madcapnmckay! Thanks! |
I'm working on it... |
I'm also interested in the KO 2.x version, if you can share what you alredy have it would be great as I'm searching a context menu binding |
I tried the dropdown control with the latest version of Knockout it did not seem to like it. Thats a pity because that's about the only UI plugin I know that works with Knockout and looks fantastic.
The text was updated successfully, but these errors were encountered: