Remove custom I-beam mouse cursor shape and support "no" cursor #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychin
force-pushed
the
mouseshape-support-remove-custom-ibeam
branch
from
abdcc57
to
f1e735a
Compare
The old custom I-beam cursor does not have a HiDPI version, and looks out of place in MacVim compared to the native I-beam cursor. The rationale for its addition (add white border around the cursor for visibility) also seems to not matter anymore as macOS has had its cursors revamped since 10.7.3. Remove the custom cursor for now. Also support the "no" cursor shape, which shows up when "Press Enter" prompt comes up. For the other 'mouseshape' cursors just remove the TODO and explicitly decide not to implement them as they are a little obscure and don't have system native shapes. Could add them later as custom cursors but not worth doing so now. Fix macvim-dev#755
ychin
force-pushed
the
mouseshape-support-remove-custom-ibeam
branch
from
f1e735a
to
5516843
Compare
ychin
added a commit
to ychin/macvim
that referenced
this pull request
Oct 28, 2019
Prevoiusly, macvim-dev#859 removed the custom high-contrast I-beam mouse cursor in favor of using the system-default I-beam cursor. However, it mostly worked well on 10.14 Mojave or above, as the cursor is designed with dark mode in mind and works well on both bright and dark backgrounds. Since this doesn't work well on older macOS versions, add back the custom cursor and only enable it on those older macOS versions. Fix macvim-dev#910.
This was referenced Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old custom I-beam cursor does not have a HiDPI version, and looks out of place in MacVim compared to the native I-beam cursor. The rationale for its addition (add white border around the cursor for visibility) also seems to not matter anymore as macOS has had its cursors revamped since 10.7.3. Remove the custom cursor for now.
Also support the "no" cursor shape, which shows up when "Press Enter" prompt comes up.
For the other 'mouseshape' cursors just remove the TODO and explicitly decide not to implement them as they are a little obscure and don't have system native shapes. Could add them later as custom cursors but not worth doing so now.
Fix #755