Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacVim snapshot 159 vim spell randomly flagging first word in lines #971

Closed
trondbn opened this issue Oct 23, 2019 · 4 comments
Closed

MacVim snapshot 159 vim spell randomly flagging first word in lines #971

trondbn opened this issue Oct 23, 2019 · 4 comments
Milestone
snapshot-160

Comments

@trondbn
Copy link

trondbn commented Oct 23, 2019

Describe the bug
MacVim snapshot 159 vim spell randomly marks a lot of words that appear first in their line as bad. First suggested correction seems to always be capitalizing the word, but after accepting this it is still marked as bad.

To Reproduce
Detailed steps to reproduce the behavior:

  1. Run mvim --clean
  2. Edit a text file, such as the one attached to this report.
  3. Type ':set spell'
  4. Red squiggly lines:
    Screenshot 2019-10-23 at 10 09 50

Expected behavior
Less squiggling: (taken with snapshot 157)
Screenshot 2019-10-23 at 10 13 39

Environment:

  • Vim version: 8.1.2168
  • OS: macOS 10.15 Catalina (19A602)
  • Terminal: GUI

Additional context
Cleaning out ~/.vim/spell/ does not help

Sample file
lorem_ipsum.txt
@ychin ychin added this to the snapshot-160 milestone Oct 23, 2019
@ychin
Copy link
Member

ychin commented Oct 23, 2019

I think this is vim/vim#5072 which was fixed in vim/vim@7751d1d (v8.1.2172). There should be an update soon to address app notarization issues which will come with this.

@chrisbra
Copy link
Contributor

We had a recent discussion about this at vi.stackexchange.com

Copying here my answer from there:

This is a known bug, introduced by patch v8.1.2153 that has since been fixed with patch v8.1.2172, so you'd need to update your MacVim to a new Version.

ychin added a commit to ychin/macvim that referenced this issue Oct 28, 2019
@ychin
MacVim Snapshot 160
02870c4 
Vim patch 8.1.2224

General:

- MacVim **now requires macOS 10.9**, up from 10.8.
- MacVim binary is now notaraized by Apple. This should make it open
  properly without a security warning in macOS 10.15 Catalina. macvim-dev#959 macvim-dev#825

Features:

- Make mouse cursor higher contrast under macOS 10.13 or older. macvim-dev#910

Fixes:

- Fix OS appearance (dark vs light mode) detection not working. See
  `:help OSAppearanceChanged` for more info on the feature.  macvim-dev#973
- Fix spell checker flagging first words in line. macvim-dev#971 (Vim 8.1.2172)
- Fix wrong highlighting color scheme. macvim-dev#960 (Vim 8.1.2176)

Misc:

- Sparkle updater has been updated to 1.22.00. macvim-dev#963

Targets macOS 10.9+

Script interfaces have compatibility with these versions:

- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.7
- Ruby 2.6
@eirnym
Copy link
Contributor

eirnym commented Oct 28, 2019

@trondbn snapshot 160, please check it

ychin added a commit that referenced this issue Oct 29, 2019
@ychin
MacVim Snapshot 160
f24dd52 
Vim patch 8.1.2224

General:

- MacVim **now requires macOS 10.9**, up from 10.8.
- MacVim binary is now notaraized by Apple. This should make it open
  properly without a security warning in macOS 10.15 Catalina. #959 #825

Features:

- Make mouse cursor higher contrast under macOS 10.13 or older. #910

Fixes:

- Fix OS appearance (dark vs light mode) detection not working. See
  `:help OSAppearanceChanged` for more info on the feature.  #973
- Fix spell checker flagging first words in line. #971 (Vim 8.1.2172)
- Fix wrong highlighting color scheme. #960 (Vim 8.1.2176)

Misc:

- Sparkle updater has been updated to 1.22.00. #963

Targets macOS 10.9+

Script interfaces have compatibility with these versions:

- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.7
- Ruby 2.6
@trondbn
Copy link
Author

trondbn commented Oct 29, 2019

Confirmed fixed in snapshot 160.

@trondbn trondbn closed this as completed Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
snapshot-160
Development

No branches or pull requests
4 participants
@chrisbra @eirnym @ychin @trondbn